Skip to content

Commit c5c50dd

Browse files
committed
broker: drop uuid from "hello" log messages
Problem: we toss uuids into the logs like they are going to be useful for debugging but we really don't have any way to use those for anything and they reduce the signal/noise ratio. Drop uuids from the "hello" log messages.
1 parent 053d358 commit c5c50dd

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/broker/overlay.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,10 +1092,9 @@ static void hello_request_handler (struct overlay *ov, const flux_msg_t *msg)
10921092
*/
10931093
if (subtree_is_online (child->status)) { // crash
10941094
flux_log (ov->h, LOG_ERR,
1095-
"%s (rank %lu) reconnected after crash, dropping old uuid %s",
1095+
"%s (rank %lu) reconnected after crash, dropping old connection state",
10961096
flux_get_hostbyrank (ov->h, child->rank),
1097-
(unsigned long)child->rank,
1098-
child->uuid);
1097+
(unsigned long)child->rank);
10991098
overlay_child_status_update (ov, child, SUBTREE_STATUS_LOST);
11001099
hello_log_level = LOG_ERR; // want hello log to stand out in this case
11011100
}
@@ -1112,10 +1111,9 @@ static void hello_request_handler (struct overlay *ov, const flux_msg_t *msg)
11121111

11131112
flux_log (ov->h,
11141113
hello_log_level,
1115-
"accepting connection from %s (rank %lu) uuid %s status %s",
1114+
"accepting connection from %s (rank %lu) status %s",
11161115
flux_get_hostbyrank (ov->h, child->rank),
11171116
(unsigned long)child->rank,
1118-
child->uuid,
11191117
subtree_status_str (child->status));
11201118

11211119
if (!(response = flux_response_derive (msg, 0))
@@ -1126,10 +1124,9 @@ static void hello_request_handler (struct overlay *ov, const flux_msg_t *msg)
11261124
return;
11271125
error_log:
11281126
flux_log (ov->h, LOG_ERR,
1129-
"rejecting connection from %s (rank %lu) uuid %s: %s",
1127+
"rejecting connection from %s (rank %lu): %s",
11301128
flux_get_hostbyrank (ov->h, rank),
11311129
(unsigned long)rank,
1132-
uuid,
11331130
reason);
11341131
error:
11351132
if (!(response = flux_response_derive (msg, errno))

0 commit comments

Comments
 (0)