Skip to content

Commit c73aa4f

Browse files
committed
testsuite: enhance tests for !d conversion spec
Problem: t2800-jobs-cmd.t does not test a couple use cases of the `!d` format specifier. Ensure `!d` works as expected when the `h` suffix is utilized, and that `!d` works when used without a format.
1 parent 16a8b6f commit c73aa4f

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

t/t2800-jobs-cmd.t

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,9 +937,20 @@ test_expect_success 'flux-jobs --format={expiration!d:%FT%T::>20.20} works' '
937937
cat expiration.in | \
938938
flux jobs --from-stdin -o "{expiration!d:%b%d %R::>20.20}" \
939939
>exp-fmt.out &&
940+
cat expiration.in | \
941+
flux jobs --from-stdin -o "{expiration!d:%b%d %R::>20.20h}" \
942+
>exp-fmth.out &&
940943
test_debug "cat exp-fmt.out" &&
941944
grep " EXPIRATION" exp-fmt.out &&
942-
grep " $(date --date=@${exp} +%b%d\ %R)" exp-fmt.out
945+
grep " $(date --date=@${exp} +%b%d\ %R)" exp-fmt.out &&
946+
test_debug "cat exp-fmth.out" &&
947+
grep " EXPIRATION" exp-fmth.out &&
948+
grep " $(date --date=@${exp} +%b%d\ %R)" exp-fmth.out
949+
'
950+
test_expect_success 'flux-jobs --format={expiration!d} works' '
951+
cat expiration.in | flux jobs --from-stdin -o "{expiration!d}" \
952+
>exp-fmtd.out &&
953+
grep "$(date --date=@${exp} +%FT%T)" exp-fmtd.out
943954
'
944955
test_expect_success 'flux-jobs --format={expiration!d:%FT%T::=^20} works' '
945956
cat expiration.in | \
@@ -1002,13 +1013,14 @@ test_expect_success 'flux-jobs emits empty string for special case t_estimate' '
10021013
fmt="${fmt},{annotations.sched.t_estimate!D}" &&
10031014
fmt="${fmt},{annotations.sched.t_estimate!F}" &&
10041015
fmt="${fmt},{annotations.sched.t_estimate!H}" &&
1016+
fmt="${fmt},{annotations.sched.t_estimate!d:%H:%M::h}" &&
10051017
fmt="${fmt},{annotations.sched.t_estimate!D:h}" &&
10061018
fmt="${fmt},{annotations.sched.t_estimate!F:h}" &&
10071019
fmt="${fmt},{annotations.sched.t_estimate!H:h}" &&
10081020
flux jobs -no "${fmt}" >t_estimate_annotations.out 2>&1 &&
10091021
test_debug "cat t_estimate_annotations.out" &&
10101022
for i in `seq 1 $(state_count active)`; do
1011-
echo ",,,,,-,-,-" >> t_estimate_annotations.exp
1023+
echo ",,,,,-,-,-,-" >> t_estimate_annotations.exp
10121024
done &&
10131025
test_cmp t_estimate_annotations.out t_estimate_annotations.exp
10141026
'

0 commit comments

Comments
 (0)