Skip to content

Commit c7e8017

Browse files
chu11mergify[bot]
authored andcommitted
job-list: correct out of date comments
Problem: A number of comments still refer to the module as job-info instead of job-list. Solution: Update comments appropriately.
1 parent e60d857 commit c7e8017

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/modules/job-list/idsync.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* SPDX-License-Identifier: LGPL-3.0
99
\************************************************************/
1010

11-
/* idsync.c - code to sync job ids if job-info not yet aware of them */
11+
/* idsync.c - code to sync job ids if job-list not yet aware of them */
1212

1313
#if HAVE_CONFIG_H
1414
#include "config.h"

src/modules/job-list/job_state.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1743,8 +1743,8 @@ static int journal_process_event (struct job_state_ctx *jsctx, json_t *event)
17431743
return -1;
17441744
}
17451745
else if (!strcmp (name, "flux-restart")) {
1746-
/* Presently, job-info depends on job-manager.events-journal
1747-
* service. So if job-manager reloads, job-info must be
1746+
/* Presently, job-list depends on job-manager.events-journal
1747+
* service. So if job-manager reloads, job-list must be
17481748
* reloaded, making the probability of reaching this
17491749
* `flux-restart` path very low. Code added for completeness
17501750
* and in case dependency removed in the future.

src/modules/job-list/list.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,12 +301,12 @@ void check_id_valid_continuation (flux_future_t *f, void *arg)
301301
goto cleanup;
302302
}
303303
else {
304-
/* Job ID is legal. Chance job-info has seen ID since this
304+
/* Job ID is legal. Chance job-list has seen ID since this
305305
* lookup was done */
306306
struct job *job;
307307
if (!(job = zhashx_lookup (ctx->jsctx->index, &isd->id))
308308
|| job->state == FLUX_JOB_STATE_NEW) {
309-
/* Must wait for job-info to see state change */
309+
/* Must wait for job-list to see state change */
310310
if (wait_id_valid (ctx, isd) < 0)
311311
flux_log_error (ctx->h, "%s: wait_id_valid", __FUNCTION__);
312312
goto cleanup;
@@ -343,7 +343,7 @@ int check_id_valid (struct list_ctx *ctx,
343343
char path[256];
344344
int saved_errno;
345345

346-
/* Check to see if the ID is legal, job-info may have not yet
346+
/* Check to see if the ID is legal, job-list may have not yet
347347
* seen the ID publication yet */
348348
if (flux_job_kvs_key (path, sizeof (path), id, NULL) < 0)
349349
goto error;
@@ -416,7 +416,7 @@ json_t *get_job_by_id (struct list_ctx *ctx,
416416
flux_log_error (ctx->h, "%s: idsync_data_create", __FUNCTION__);
417417
return NULL;
418418
}
419-
/* Must wait for job-info to see state change */
419+
/* Must wait for job-list to see state change */
420420
if (wait_id_valid (ctx, isd) < 0) {
421421
flux_log_error (ctx->h, "%s: wait_id_valid", __FUNCTION__);
422422
return NULL;

0 commit comments

Comments
 (0)