Skip to content

Commit d0597ee

Browse files
committed
python: remove "all" filter name in add_filter()
Problem: The JobList class's add_filter() function checks for the special filter name "all" and sets the filter to pending and running. As far as I can tell, the special filter name "all" has never been supported or documented. In addition, it doesn't make much sense since it should set pending, running, and inactive to get all jobs. My suspicion is this may be left over code from development that did not get removed. Remove check for the filter name "all".
1 parent 976b089 commit d0597ee

File tree

1 file changed

+0
-5
lines changed
  • src/bindings/python/flux/job

1 file changed

+0
-5
lines changed

src/bindings/python/flux/job/list.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -236,11 +236,6 @@ def set_user(self, user):
236236
def add_filter(self, fname):
237237
"""Append a state or result filter to JobList query"""
238238
fname = fname.lower()
239-
if fname == "all":
240-
self.states |= self.STATES["pending"]
241-
self.states |= self.STATES["running"]
242-
return
243-
244239
if fname in self.STATES:
245240
self.states |= self.STATES[fname]
246241
elif fname in self.RESULTS:

0 commit comments

Comments
 (0)