Skip to content

Commit d8f2f10

Browse files
garlickchu11
authored andcommitted
job-list: make replay KVS errors non-fatal
Problem: the job manager now treats jobs that cannot be loaded from the KVS as a non-fatal error, but job-list treats them as fatal still. Relax error handling so that replay continues if a job cannot be loaded. Most likely the job will have already been logged by the job manager so introduce no new logging here.
1 parent 2e23a37 commit d8f2f10

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/modules/job-list/job_state.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ static int depthfirst_map_one (struct job_state_ctx *jsctx,
673673
flux_future_t *f3 = NULL;
674674
const char *eventlog, *jobspec, *R;
675675
char path[64];
676-
int rc = -1;
676+
int rc = 0; // non-fatal error
677677

678678
if (strlen (key) <= dirskip) {
679679
errno = EINVAL;
@@ -736,7 +736,7 @@ static int depthfirst_map_one (struct job_state_ctx *jsctx,
736736

737737
rc = 1;
738738
done:
739-
if (rc < 0)
739+
if (rc == 0)
740740
job_destroy (job);
741741
flux_future_destroy (f1);
742742
flux_future_destroy (f2);

0 commit comments

Comments
 (0)