Merge pull request #5251 from garlick/unwrap_fail

mergify[bot] · web-flow · commit d9712cf7d599 · 2023-06-12T14:28:03.000Z
libjob: return on error in unwrap_string()
diff --git a/src/common/libjob/unwrap.c b/src/common/libjob/unwrap.c
@@ -80,6 +80,7 @@ char *unwrap_string (const char *s,
         errprintf (errp,
                    "failed to create security context: %s",
                    strerror (errno));
+        return NULL;
     }
     if (flux_security_configure (sec, NULL) < 0) {
         errprintf (errp,

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,7 @@ char unwrap_string (const char s,`
`80`	`80`	`errprintf (errp,`
`81`	`81`	`"failed to create security context: %s",`
`82`	`82`	`strerror (errno));`
	`83`	`+ return NULL;`
`83`	`84`	`}`
`84`	`85`	`if (flux_security_configure (sec, NULL) < 0) {`
`85`	`86`	`errprintf (errp,`