Add missing include of config.h in tests

chu11 · chu11 · commit f841119df4d6 · 2023-05-25T08:01:15.000-07:00
Problem: A number of test C files did not include config.h. It should be included if the test code uses internal libraries to aid in testing (log, xzmalloc, ccan, etc.). Globally add it when it is missing. Fixes #5167
diff --git a/src/common/libeventlog/test/eventlog.c b/src/common/libeventlog/test/eventlog.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 #include <string.h>
 #include <stdarg.h>
diff --git a/src/common/libflux/test/buffer.c b/src/common/libflux/test/buffer.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
diff --git a/src/common/libflux/test/msg_handler.c b/src/common/libflux/test/msg_handler.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <flux/core.h>
 
 #include "src/common/libflux/msg_handler.h"
diff --git a/src/common/libflux/test/panic.c b/src/common/libflux/test/panic.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 #include <string.h>
 #include <flux/core.h>
diff --git a/src/common/libflux/test/plugin.c b/src/common/libflux/test/plugin.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <errno.h>
 
diff --git a/src/common/libflux/test/reactor.c b/src/common/libflux/test/reactor.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 #include <sys/types.h>
 #include <sys/socket.h>
diff --git a/src/common/libflux/test/request.c b/src/common/libflux/test/request.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 #include <string.h>
 
diff --git a/src/common/libflux/test/response.c b/src/common/libflux/test/response.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <errno.h>
 #include <flux/core.h>
diff --git a/src/common/libflux/test/rpc_security.c b/src/common/libflux/test/rpc_security.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 #include <flux/core.h>
 #include <inttypes.h>
diff --git a/src/common/libflux/test/tagpool.c b/src/common/libflux/test/tagpool.c
@@ -8,6 +8,10 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
+
 #include "src/common/libflux/message.h"
 #include "src/common/libflux/tagpool.h"
 #include "src/common/libtap/tap.h"
diff --git a/src/common/libflux/test/version.c b/src/common/libflux/test/version.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 
 #include "src/common/libflux/version.h"
diff --git a/src/common/libioencode/test/ioencode.c b/src/common/libioencode/test/ioencode.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <stdio.h>
 #include <string.h>
 #include <jansson.h>
diff --git a/src/common/libkvs/test/treeobj.c b/src/common/libkvs/test/treeobj.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <errno.h>
 
diff --git a/src/common/liboptparse/test/optparse.c b/src/common/liboptparse/test/optparse.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
diff --git a/src/common/libpmi/test/keyval.c b/src/common/libpmi/test/keyval.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <ctype.h>
 
diff --git a/src/common/libpmi/test/kvstest.c b/src/common/libpmi/test/kvstest.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <stdio.h>
 #include <unistd.h>
 #include <stdlib.h>
diff --git a/src/common/libpmi/test/kvstest2.c b/src/common/libpmi/test/kvstest2.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <stdio.h>
 #include <unistd.h>
 #include <stdlib.h>
diff --git a/src/common/libpmi/test/pmi2_info.c b/src/common/libpmi/test/pmi2_info.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <stdio.h>
 #include <unistd.h>
 #include <stdlib.h>
diff --git a/src/common/libpmi/test/pmi_info.c b/src/common/libpmi/test/pmi_info.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <stdio.h>
 #include <unistd.h>
 #include <stdlib.h>
diff --git a/src/common/librlist/test/match.c b/src/common/librlist/test/match.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 
 #include "src/common/libtap/tap.h"
diff --git a/src/common/librlist/test/rhwloc.c b/src/common/librlist/test/rhwloc.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <flux/hostlist.h>
 
 #include "src/common/libtap/tap.h"
diff --git a/src/common/librlist/test/rlist.c b/src/common/librlist/test/rlist.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <unistd.h>
 #include <errno.h>
 #include <jansson.h>
diff --git a/src/common/librlist/test/rnode.c b/src/common/librlist/test/rnode.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 
 #include "src/common/libtap/tap.h"
diff --git a/src/common/libsubprocess/test/cmd.c b/src/common/libsubprocess/test/cmd.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <assert.h>
 #include <jansson.h>
 
diff --git a/src/common/libsubprocess/test/subprocess.c b/src/common/libsubprocess/test/subprocess.c
@@ -8,8 +8,10 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <assert.h>
-
 #include <flux/core.h>
 #include <unistd.h>
 #include <fcntl.h>
diff --git a/src/common/libutil/test/aux.c b/src/common/libutil/test/aux.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <errno.h>
 
diff --git a/src/common/libutil/test/blobref.c b/src/common/libutil/test/blobref.c
@@ -8,8 +8,12 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <errno.h>
+
 #include "src/common/libtap/tap.h"
 #include "src/common/libutil/blobref.h"
 #include "src/common/libutil/sha1.h"
diff --git a/src/common/libutil/test/cronodate.c b/src/common/libutil/test/cronodate.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #define _XOPEN_SOURCE 700
 #include <stdlib.h>
 #include <time.h>
diff --git a/src/common/libutil/test/environment.c b/src/common/libutil/test/environment.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 
 #include "ccan/str/str.h"
diff --git a/src/common/libutil/test/fdutils.c b/src/common/libutil/test/fdutils.c
@@ -8,10 +8,14 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <unistd.h>
 #include <errno.h>
 #include <string.h>
 #include <fcntl.h>
+
 #include "src/common/libtap/tap.h"
 #include "src/common/libutil/fdutils.h"
 
diff --git a/src/common/libutil/test/fdwalk.c b/src/common/libutil/test/fdwalk.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <unistd.h>
 #include <errno.h>
 #include <string.h>
diff --git a/src/common/libutil/test/fsd.c b/src/common/libutil/test/fsd.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <math.h>
 #include <string.h>
 #include <errno.h>
diff --git a/src/common/libutil/test/grudgeset.c b/src/common/libutil/test/grudgeset.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <errno.h>
 #include <jansson.h>
diff --git a/src/common/libutil/test/hola.c b/src/common/libutil/test/hola.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <errno.h>
 
 #include "src/common/libtap/tap.h"
diff --git a/src/common/libutil/test/intree.c b/src/common/libutil/test/intree.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <errno.h>
 #include <pthread.h>
diff --git a/src/common/libutil/test/ipaddr.c b/src/common/libutil/test/ipaddr.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <sys/param.h>
 
 #include "src/common/libtap/tap.h"
diff --git a/src/common/libutil/test/kary.c b/src/common/libutil/test/kary.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include "src/common/libtap/tap.h"
 #include "src/common/libutil/kary.h"
 
diff --git a/src/common/libutil/test/popen2.c b/src/common/libutil/test/popen2.c
@@ -8,6 +8,9 @@
  * SPDX-License-Identifier: LGPL-3.0
 \************************************************************/
 
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
 #include <string.h>
 #include <errno.h>
 #include <stdint.h>
diff --git a/src/common/libutil/test/stdlog.c b/src/common/libutil/test/stdlog.c
diff --git a/src/common/libutil/test/strstrip.c b/src/common/libutil/test/strstrip.c
diff --git a/src/common/libutil/test/unlink.c b/src/common/libutil/test/unlink.c
diff --git a/src/common/libutil/test/veb.c b/src/common/libutil/test/veb.c
diff --git a/src/common/libutil/test/wallclock.c b/src/common/libutil/test/wallclock.c
diff --git a/src/common/libzmqutil/test/reactor.c b/src/common/libzmqutil/test/reactor.c
diff --git a/t/kvs/issue1876.c b/t/kvs/issue1876.c
diff --git a/t/kvs/waitcreate_cancel.c b/t/kvs/waitcreate_cancel.c
diff --git a/t/sched-simple/jj-reader.c b/t/sched-simple/jj-reader.c
diff --git a/t/stats/stats-basic.c b/t/stats/stats-basic.c
diff --git a/t/stats/stats-immediate.c b/t/stats/stats-immediate.c
