flux-admin: drop unused command

Problem: flux admin cleanup-push is no longer needed.

Drop the flux-admin command (that was the only subcommand).
Drop bash completion.
Drop the broker runat.push RPC.
Update the flux(1) help output test.

Author: garlick

etc/completions/flux.pre

@@ -883,25 +883,6 @@ _flux_config()
     return 0
 }
 
-# flux-admin(8) completions
-_flux_admin()
-{
-    local cmd=$1
-    local subcmds="cleanup-push"
-
-    if [[ $cmd != "admin" ]]; then
-        var="${cmd//-/_}_OPTS"
-        COMPREPLY=( $(compgen -W "${!var} -h --help" -- "$cur") )
-        if [[ "${COMPREPLY[@]}" == *= ]]; then
-            # Add space if there is not a '=' in suggestions
-            compopt -o nospace
-        fi
-    else
-        COMPREPLY=( $(compgen -W "${subcmds}" -- "$cur") )
-    fi
-    return 0
-}
-
 # flux-module(1) completions
 _flux_module()
 {

src/broker/runat.c

@@ -65,7 +65,6 @@ struct runat {
     flux_t *h;
     const char *local_uri;
     zhashx_t *entries;
-    flux_msg_handler_t **handlers;
     bool sd_notify;
     struct termios saved_termios;
 };
@@ -637,58 +636,6 @@ int runat_abort (struct runat *r, const char *name)
     return 0;
 }
 
-static void runat_push_cb (flux_t *h,
-                           flux_msg_handler_t *mh,
-                           const flux_msg_t *msg,
-                           void *arg)
-{
-    struct runat *r = arg;
-    const char *name;
-    json_t *commands;
-    const char *errstr = NULL;
-    size_t index;
-    json_t *el;
-
-    if (flux_request_unpack (msg,
-                             NULL,
-                             "{s:s s:o}",
-                             "name",
-                             &name,
-                             "commands",
-                             &commands) < 0)
-        goto error;
-    if (json_array_size (commands) == 0) {
-        errno = EPROTO;
-        errstr = "commands array is empty";
-        goto error;
-    }
-    json_array_foreach (commands, index, el) {
-        const char *cmdline = json_string_value (el);
-        if (!cmdline || strlen (cmdline) == 0) {
-            errno = EPROTO;
-            errstr = "cannot push an empty command line";
-            goto error;
-        }
-        if (runat_push_shell_command (r,
-                                      name,
-                                      cmdline,
-                                      RUNAT_FLAG_LOG_STDIO) < 0)
-            goto error;
-    }
-    if (flux_respond (h, msg, NULL) < 0)
-        flux_log (h, LOG_ERR, "error responding to runat.push");
-    return;
-error:
-    if (flux_respond_error (h, msg, errno, errstr) < 0)
-        flux_log (h, LOG_ERR, "error responding to runat.push");
-}
-
-
-static const struct flux_msg_handler_spec htab[] = {
-    { FLUX_MSGTYPE_REQUEST,  "runat.push", runat_push_cb, 0 },
-    FLUX_MSGHANDLER_TABLE_END,
-};
-
 struct runat *runat_create (flux_t *h, const char *local_uri, bool sdnotify)
 {
     struct runat *r;
@@ -697,8 +644,6 @@ struct runat *runat_create (flux_t *h, const char *local_uri, bool sdnotify)
         return NULL;
     if (!(r->entries = zhashx_new ()))
         goto error;
-    if (flux_msg_handler_addvec (h, htab, r, &r->handlers) < 0)
-        goto error;
     zhashx_set_destructor (r->entries, runat_entry_destroy_wrapper);
     r->h = h;
     r->local_uri = local_uri;
@@ -717,7 +662,6 @@ void runat_destroy (struct runat *r)
     if (r) {
         int saved_errno = errno;
         zhashx_destroy (&r->entries);
-        flux_msg_handler_delvec (r->handlers);
         free (r);
         errno = saved_errno;
     }

src/cmd/Makefile.am

@@ -105,7 +105,6 @@ dist_fluxcmd_SCRIPTS = \
 	flux-jobs.py \
 	flux-fortune.py \
 	flux-resource.py \
-	flux-admin.py \
 	flux-jobtap.py \
 	flux-job-validator.py \
 	flux-job-frobnicator.py \

src/cmd/flux-admin.py

@@ -818,7 +818,6 @@ test_expect_success 'no unit tests built with libtool wrapper' '
 
 CMDS="\
 R \
-admin \
 cron \
 event \
 exec \