job-list: support 'all' job-list attr

Problem: As the number of attributes grows in `job-list`, it is
becoming inconvenient for users to get "all" (or most) attributes
for a job.

Solution: Support a special case attribute "all" which will return
all attributes for a job.

Fixes #4313

Author: chu11

src/bindings/python/flux/job/list.py

@@ -42,6 +42,7 @@
     "expiration",
     "annotations",
     "dependencies",
+    "all",
 ]
 
 

src/modules/job-list/job_util.c

@@ -16,9 +16,11 @@
 #include <jansson.h>
 #include <stdarg.h>
 #include <flux/core.h>
+#include <assert.h>
 
 #include "src/common/libutil/errno_safe.h"
 
+#include "job-list.h"
 #include "job_util.h"
 #include "job_state.h"
 
@@ -180,6 +182,21 @@ static int store_attr (struct job *job,
     return 0;
 }
 
+int store_all_attr (struct job *job, json_t *o, job_list_error_t *errp)
+{
+    const char **ptr = job_attrs ();
+
+    assert (ptr);
+
+    while (*ptr) {
+        if (store_attr (job, *ptr, o, errp) < 0)
+            return -1;
+        ptr++;
+    }
+
+    return 0;
+}
+
 /* For a given job, create a JSON object containing the jobid and any
  * additional requested attributes and their values.  Returns JSON
  * object which the caller must free.  On error, return NULL with
@@ -212,8 +229,14 @@ json_t *job_to_json (struct job *job, json_t *attrs, job_list_error_t *errp)
             errno = EINVAL;
             goto error;
         }
-        if (store_attr (job, attr, o, errp) < 0)
-            goto error;
+        if (strcmp (attr, "all") == 0) {
+            if (store_all_attr (job, o, errp) < 0)
+                goto error;
+        }
+        else {
+            if (store_attr (job, attr, o, errp) < 0)
+                goto error;
+        }
     }
     return o;
  error_nomem:

src/modules/job-list/list.c

@@ -574,6 +574,9 @@ void list_attrs_cb (flux_t *h, flux_msg_handler_t *mh,
             goto error;
     }
 
+    if (list_attrs_append (a, "all") < 0)
+        goto error;
+
     if (flux_respond_pack (h, msg, "{s:O}", "attrs", a) < 0)
         flux_log_error (h, "%s: flux_respond_pack", __FUNCTION__);