Skip to content

Commit 512f507

Browse files
committed
reduce unnecessary logging
Problem: several log messages are not helpful and decrease the signal to noise ratio in the Flux log buffer in a large Flux instance. Eliminate logging of: - alloc success/denied/canceled - free success - resource-status success Fixes #1185
1 parent 2230264 commit 512f507

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

qmanager/modules/qmanager.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,6 @@ static void status_request_cb (flux_t *h, flux_msg_handler_t *w,
296296
flux_log_error (h, "%s: flux_respond_raw", __FUNCTION__);
297297
goto out;
298298
}
299-
flux_log (h, LOG_DEBUG, "%s: resource-status succeeded", __FUNCTION__);
300299
flux_future_destroy (f);
301300
return;
302301

qmanager/modules/qmanager_callbacks.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ int qmanager_cb_t::post_sched_loop (flux_t *h, schedutil_t *schedutil,
7070
__FUNCTION__, queue_name.c_str ());
7171
goto out;
7272
}
73-
flux_log (h, LOG_DEBUG, "alloc success (queue=%s id=%jd)",
74-
queue_name.c_str (), static_cast<intmax_t> (job->id));
7573
}
7674
while ( (job = queue->rejected_pop ()) != nullptr) {
7775
std::string note = "alloc denied due to type=\"" + job->note + "\"";
@@ -83,17 +81,13 @@ int qmanager_cb_t::post_sched_loop (flux_t *h, schedutil_t *schedutil,
8381
__FUNCTION__, queue_name.c_str ());
8482
goto out;
8583
}
86-
flux_log (h, LOG_DEBUG, "%s (id=%jd queue=%s)", note.c_str (),
87-
static_cast<intmax_t> (job->id), queue_name.c_str ());
8884
}
8985
while ( (job = queue->canceled_pop ()) != nullptr) {
9086
if (schedutil_alloc_respond_cancel (schedutil, job->msg) < 0) {
9187
flux_log_error (h, "%s: schedutil_alloc_respond_cancel",
9288
__FUNCTION__);
9389
goto out;
9490
}
95-
flux_log (h, LOG_DEBUG, "%s (id=%jd queue=%s)", "alloc canceled",
96-
static_cast<intmax_t> (job->id), queue_name.c_str ());
9791
}
9892
for (job = queue->pending_begin (), qd = 0;
9993
job != nullptr && qd < queue->get_queue_depth ();
@@ -289,8 +283,6 @@ void qmanager_cb_t::jobmanager_free_cb (flux_t *h, const flux_msg_t *msg,
289283
flux_log_error (h, "%s: schedutil_free_respond", __FUNCTION__);
290284
return;
291285
}
292-
flux_log (h, LOG_DEBUG, "free succeeded (queue=%s id=%jd)",
293-
queue_name.c_str (), static_cast<intmax_t> (id));
294286
}
295287

296288
void qmanager_cb_t::jobmanager_cancel_cb (flux_t *h, const flux_msg_t *msg,

resource/modules/resource_match.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2575,7 +2575,6 @@ static void status_request_cb (flux_t *h, flux_msg_handler_t *w,
25752575
flux_log_error (h, "%s: flux_respond_pack", __FUNCTION__);
25762576
goto error;
25772577
}
2578-
flux_log (h, LOG_DEBUG, "%s: status succeeded", __FUNCTION__);
25792578
return;
25802579

25812580
error:

0 commit comments

Comments
 (0)