reapi: simplify build entries for go tests

Problem: the Go test links against unnecessary libraries such as Fluxion
resource, reapi_module, and flux::core. Furthermore, the options are a
long, unwrapped string which is hard to read.

Remove the unnecessary entries in the CGO_LIBRARY_FLAGS and make the
presentation more readable. Update GolangSimple.cmake to remove string
replacement of " " with ";" which causes the list expansion to fail.

Author: milroy

cmake/GolangSimple.cmake

@@ -11,11 +11,8 @@ function(BUILD_GO_PROGRAM NAME MAIN_SRC CGO_CFLAGS CGO_LIBRARY_FLAGS)
   get_filename_component(MAIN_SRC_ABS ${MAIN_SRC} ABSOLUTE)
   add_custom_target(${NAME})
 
-  # IMPORTANT: the trick to getting *spaces* to render in COMMAND is to convert them to ";"
-  # string(REPLACE <match-string> <replace-string> <out-var> <input>...)
-  STRING(REPLACE " " ";" CGO_LIBRARY_FLAGS ${CGO_LIBRARY_FLAGS})  
   add_custom_command(TARGET ${NAME}
-                    COMMAND GOPATH=${GOPATH}:${CUSTOM_GO_PATH} GOOS=linux G0111MODULE=off CGO_CFLAGS="${CGO_CFLAGS}" CGO_LDFLAGS='${CGO_LIBRARY_FLAGS}' go build -ldflags '-w'
+                    COMMAND GOPATH=${GOPATH}:${CUSTOM_GO_PATH} GOOS=linux G0111MODULE=off CGO_CFLAGS="${CGO_CFLAGS}" CGO_LDFLAGS="${CGO_LIBRARY_FLAGS}" go build -ldflags '-w'
                     -o "${CMAKE_CURRENT_SOURCE_DIR}/${NAME}"
                     ${CMAKE_GO_FLAGS} ${MAIN_SRC}
                     WORKING_DIRECTORY ${CMAKE_CURRENT_LIST_DIR}

resource/reapi/bindings/go/src/test/CMakeLists.txt

@@ -3,15 +3,24 @@ set(SRCS main.go)
 set(CGO_CFLAGS "-I${CMAKE_BINARY_DIR}/resource/reapi/bindings/c")
 
 # This is currently passed but not used because when passed into add_custom_command the spaces are escaped
-set(CGO_LIBRARY_FLAGS "-Wl,-R ${CMAKE_BINARY_DIR}/resource -L${CMAKE_BINARY_DIR}/resource/reapi/bindings -L${CMAKE_BINARY_DIR}/resource/libjobspec -ljobspec_conv -lreapi_cli -L${CMAKE_BINARY_DIR}/resource -lresource -L${CMAKE_BINARY_DIR}/resource/planner/c -lplanner -L${CMAKE_BINARY_DIR}/resource/planner/c++ -lplanner_cxx -lflux-idset -lstdc++ -lczmq -ljansson -lhwloc -lboost_system -lflux-hostlist -lboost_graph -lyaml-cpp")
+set(CGO_LIBRARY_FLAGS -Wl,-R
+    -lflux-idset
+    -lstdc++
+    -lczmq
+    -ljansson
+    -lhwloc
+    -lboost_system
+    -lflux-hostlist
+    -lboost_graph
+    -lyaml-cpp
+    -L${CMAKE_BINARY_DIR}/resource/reapi/bindings -lreapi_cli
+    )
 
 # This ensures the main binary is cleaned up
 set_directory_properties(
     PROPERTIES
-      ADDITIONAL_CLEAN_FILES "${CMAKE_CURRENT_BINARY_DIR}/main"
+    ADDITIONAL_CLEAN_FILES "${CMAKE_CURRENT_BINARY_DIR}/main"
   )
 
-# GO_GET(go_redis github.com/hoisie/redis)
-#                          main      main.go  
 # We add the dependencies at the end so the build can run in parallel and we don't try to build this before they are ready!
-BUILD_GO_PROGRAM(${TARGET} ${SRCS} "${CGO_CFLAGS}" "${CGO_LIBRARY_FLAGS}" jobspec_conv reapi_module reapi_cli resource flux::core)
+BUILD_GO_PROGRAM(${TARGET} ${SRCS} "${CGO_CFLAGS}" "${CGO_LIBRARY_FLAGS}" reapi_cli)