Skip to content

Commit 287f21b

Browse files
committed
rfc1: refine maintainer PR review process
Problem: RFC 1 says that maintainers must not make value judgements on correct PRs, must merge them rapidly, and must express value judgements as patches, which contradicts current project practice. Instead of "rapidly", refer to RFC 48 which is intended to provide remedies for "the maintainers are ignoring me!" problems. Adjust the "value judgement" policy so that maintainers can continue to ask contributors to rework PRs to increase their value and avoid needless churn in the commit history. This policy was likely added to C4.1 to solve a real problem with an intransigent 0MQ maintainer. We can always come up with a governance remedy if Flux finds itself in a similar situation down the road, but for now we seem to be doing OK.
1 parent 8383bfe commit 287f21b

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

spec_1.rst

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,18 +156,14 @@ Development Process
156156

157157
- Maintainers SHOULD NOT merge their own patches except in exceptional cases.
158158

159-
- Maintainers SHALL NOT make value judgments on correct patches.
160-
161-
- Maintainers SHALL merge correct patches from other Contributors rapidly.
159+
- Maintainers SHALL merge correct patches from other Contributors as described in :doc:`spec_48`.
162160

163161
- The Contributor MAY tag an issue as "Ready" after making a pull request for the issue.
164162

165163
- The user who created an issue SHOULD close the issue after checking the patch is successful.
166164

167165
- Maintainers SHOULD ask for improvements to incorrect patches and SHOULD reject incorrect patches if the Contributor does not respond constructively.
168166

169-
- Any Contributor who has value judgments on a correct patch SHOULD express these via their own patches.
170-
171167
- Maintainers MAY commit changes to non-source documentation directly to the project.
172168

173169
- Autotools products, if applicable, SHOULD NOT be checked into the project

0 commit comments

Comments
 (0)