Skip to content

Commit 445d1e9

Browse files
committed
List valid mesh providers in help and chart values
the list of values was incomplete Signed-off-by: Mara Furland <mara@fur.land>
1 parent d4cc9bf commit 445d1e9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

charts/flagger/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ serviceMonitor:
3232
# Set labels for the ServiceMonitor, use this to define your scrape label for Prometheus Operator
3333
# labels:
3434

35-
# accepted values are kubernetes, istio, linkerd, appmesh, contour, nginx, gloo, skipper, traefik, apisix
35+
# accepted values are apisix, appmesh, appmesh:v1beta2, contour, gatewayapi:v1, gatewayapi:v1beta1, gloo, istio, knative, kubernetes, kuma, linkerd, nginx, osm, skipper, smi:v1alpha1, smi:v1alpha2, smi:v1alpha3, traefik
3636
meshProvider: ""
3737

3838
# single namespace restriction

cmd/flagger/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func init() {
112112
flag.BoolVar(&zapReplaceGlobals, "zap-replace-globals", false, "Whether to change the logging level of the global zap logger.")
113113
flag.StringVar(&zapEncoding, "zap-encoding", "json", "Zap logger encoding.")
114114
flag.StringVar(&namespace, "namespace", "", "Namespace that flagger would watch canary object.")
115-
flag.StringVar(&meshProvider, "mesh-provider", "istio", "Service mesh provider, can be istio, linkerd, appmesh, contour, knative, gloo, nginx, skipper, traefik, apisix, osm or kuma.")
115+
flag.StringVar(&meshProvider, "mesh-provider", "istio", "Service mesh provider, can be apisix, appmesh, appmesh:v1beta2, contour, gatewayapi:v1, gatewayapi:v1beta1, gloo, istio, knative, kubernetes, kuma, linkerd, nginx, osm, skipper, smi:v1alpha1, smi:v1alpha2, smi:v1alpha3, or traefik.")
116116
flag.StringVar(&selectorLabels, "selector-labels", "app,name,app.kubernetes.io/name", "List of pod labels that Flagger uses to create pod selectors.")
117117
flag.StringVar(&ingressAnnotationsPrefix, "ingress-annotations-prefix", "nginx.ingress.kubernetes.io", "Annotations prefix for NGINX ingresses.")
118118
flag.StringVar(&ingressClass, "ingress-class", "", "Ingress class used for annotating HTTPProxy objects.")

0 commit comments

Comments
 (0)