Remove flagger_canary_status metric after a canary is deleted

Signed-off-by: AlbertoSH <alberto.sanz.herrero@gmail.com>

Author: AlbertoSH

pkg/controller/controller.go

@@ -296,6 +296,11 @@ func (c *Controller) syncHandler(key string) error {
 		return nil
 	}
 
+	// Clean the metrics if marked for deletion
+	if cd.ObjectMeta.DeletionTimestamp != nil {
+		c.recorder.DeleteStatus(cd)
+	}
+
 	// set status condition for new canaries
 	if cd.Status.Conditions == nil {
 		if err := c.setPhaseInitializing(cd); err != nil {

pkg/metrics/recorder.go

@@ -186,6 +186,11 @@ func (cr *Recorder) IncFailures(labels CanaryMetricLabels) {
 	cr.failures.WithLabelValues(labels.Values()...).Inc()
 }
 
+// DeleteStatus deletes the canary analysis status
+func (cr *Recorder) DeleteStatus(cd *flaggerv1.Canary) {
+	cr.status.DeleteLabelValues(cd.Spec.TargetRef.Name, cd.Namespace)
+}
+
 // GetStatusMetric returns the status metric
 func (cr *Recorder) GetStatusMetric() *prometheus.GaugeVec {
 	return cr.status