Test that the ready condition shows commit/push

After a change has been made, the ready condition should have a
message indicating that it pushed a commit.

Signed-off-by: Michael Bridgen <[email protected]>

Author: squaremo

controllers/update_test.go

@@ -36,7 +36,7 @@ import (
 	. "github.com/onsi/gomega"
 	"github.com/otiai10/copy"
 	corev1 "k8s.io/api/core/v1"
-	//	apimeta "k8s.io/apimachinery/pkg/api/meta"
+	apimeta "k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -319,6 +319,7 @@ var _ = Describe("ImageUpdateAutomation", func() {
 				}, timeout, time.Second).Should(BeTrue())
 				// check that the annotation was recorded as seen
 				Expect(newUpdate.Status.LastHandledReconcileAt).To(Equal(ts))
+				expectCommittedAndPushed(newUpdate.Status.Conditions)
 
 				// check that a new commit was made
 				compareRepoWithExpected(repoURL, branch, "testdata/appconfig-setters-expected", func(tmp string) {
@@ -329,6 +330,12 @@ var _ = Describe("ImageUpdateAutomation", func() {
 	})
 })
 
+func expectCommittedAndPushed(conditions []metav1.Condition) {
+	rc := apimeta.FindStatusCondition(conditions, meta.ReadyCondition)
+	Expect(rc).ToNot(BeNil())
+	Expect(rc.Message).To(ContainSubstring("committed and pushed"))
+}
+
 func replaceMarker(path string, policyKey types.NamespacedName) {
 	// NB this requires knowledge of what's in the git
 	// repo, so a little brittle