Skip to content

Commit 4f9da74

Browse files
committed
Tidy stray println and misleading comments
Signed-off-by: Michael Bridgen <[email protected]>
1 parent 38671db commit 4f9da74

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

controllers/update_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ var _ = Describe("ImageUpdateAutomation", func() {
247247
})
248248

249249
It("stops updating when suspended", func() {
250-
// suspend it, and check that it is marked as unready.
250+
// suspend it, and check that reconciliation does not run
251251
var updatePatch imagev1.ImageUpdateAutomation
252252
updatePatch.Name = updateKey.Name
253253
updatePatch.Namespace = updateKey.Namespace
@@ -267,15 +267,16 @@ var _ = Describe("ImageUpdateAutomation", func() {
267267
NamespacedName: updateKey,
268268
})
269269
Expect(err).To(BeNil())
270-
Expect(result).To(Equal(ctrl.Result{})) // this ought to fail, since it should be rescheduled; but if not, additional checks lie below
270+
// this ought to fail if suspend is not working, since the item would be requeued;
271+
// but if not, additional checks lie below.
272+
Expect(result).To(Equal(ctrl.Result{}))
271273

272274
var checkUpdate imagev1.ImageUpdateAutomation
273275
Expect(k8sClient.Get(context.Background(), updateKey, &checkUpdate)).To(Succeed())
274276
Expect(checkUpdate.Status.ObservedGeneration).NotTo(Equal(checkUpdate.ObjectMeta.Generation))
275277
})
276278

277279
It("runs when the reconcile request annotation is added", func() {
278-
println("[DEBUG]", updateKey.String())
279280
// the automation has run, and is not expected to run
280281
// again for 2 hours. Make a commit to the git repo
281282
// which needs to be undone by automation, then add

0 commit comments

Comments
 (0)