retry reconciliation in delete before finalizer test

aryan9600 · aryan9600 · commit 95a7b39de0c6 · 2023-08-23T18:31:43.000+05:30
Retry reconciliation in `TestImageUpdateAutomationReconciler_deleteBeforeFinalizer`
as sometimes it fails with a latest version conflict error.

Signed-off-by: Sanskar Jaiswal &lt;jaiswalsanskar078@gmail.com&gt;
diff --git a/internal/controller/update_test.go b/internal/controller/update_test.go
@@ -160,8 +160,10 @@ func TestImageUpdateAutomationReconciler_deleteBeforeFinalizer(t *testing.T) {
 		EventRecorder: record.NewFakeRecorder(32),
 	}
 	// NOTE: Only a real API server responds with an error in this scenario.
-	_, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: client.ObjectKeyFromObject(imageUpdate)})
-	g.Expect(err).NotTo(HaveOccurred())
+	g.Eventually(func() error {
+		_, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: client.ObjectKeyFromObject(imageUpdate)})
+		return err
+	}, timeout).Should(Succeed())
 }
 
 func TestImageAutomationReconciler_commitMessage(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -160,8 +160,10 @@ func TestImageUpdateAutomationReconciler_deleteBeforeFinalizer(t *testing.T) {`
`160`	`160`	`EventRecorder: record.NewFakeRecorder(32),`
`161`	`161`	`}`
`162`	`162`	`// NOTE: Only a real API server responds with an error in this scenario.`
`163`		`- _, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: client.ObjectKeyFromObject(imageUpdate)})`
`164`		`- g.Expect(err).NotTo(HaveOccurred())`
	`163`	`+ g.Eventually(func() error {`
	`164`	`+ _, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: client.ObjectKeyFromObject(imageUpdate)})`
	`165`	`+ return err`
	`166`	`+ }, timeout).Should(Succeed())`
`165`	`167`	`}`
`166`	`168`
`167`	`169`	`func TestImageAutomationReconciler_commitMessage(t *testing.T) {`