fixup! Add proxy support to Telegram notifier

Signed-off-by: cappyzawa <[email protected]>

Author: cappyzawa

internal/notifier/telegram.go

@@ -39,9 +39,9 @@ func NewTelegram(apiURL, proxyURL, channel, token string) (*Telegram, error) {
 		return nil, errors.New("empty Telegram token")
 	}
 
-	if apiURL == "" {
-		apiURL = fmt.Sprintf(defaultTelegramBaseURL, token)
-	}
+	// Note: Always ignore apiURL parameter for backward compatibility.
+	// The address field was ignored until v1.6.0.
+	apiURL = fmt.Sprintf(defaultTelegramBaseURL, token)
 
 	return &Telegram{
 		URL:      apiURL,

internal/notifier/telegram_test.go

@@ -60,11 +60,27 @@ func TestTelegram_Post(t *testing.T) {
 	}))
 	defer ts.Close()
 
-	telegram, err := NewTelegram(ts.URL, "", "channel", "token")
+	telegram, err := NewTelegram("", "", "channel", "token")
 	require.NoError(t, err)
 
+	telegram.URL = ts.URL
+
 	ev := testEvent()
 	ev.Metadata["kubernetes.io/somekey"] = "some.value"
 	err = telegram.Post(context.TODO(), ev)
 	require.NoError(t, err)
 }
+
+func TestTelegram_NewTelegram_IgnoresAddress(t *testing.T) {
+	telegram, err := NewTelegram("https://api.telegram.org", "", "channel", "token")
+	require.NoError(t, err)
+	require.Equal(t, "https://api.telegram.org/bottoken", telegram.URL)
+
+	telegram2, err := NewTelegram("https://custom.example.com", "", "channel", "token")
+	require.NoError(t, err)
+	require.Equal(t, "https://api.telegram.org/bottoken", telegram2.URL)
+
+	telegram3, err := NewTelegram("", "", "channel", "token")
+	require.NoError(t, err)
+	require.Equal(t, "https://api.telegram.org/bottoken", telegram3.URL)
+}