Merge pull request #969 from pjbgf/postbuild

build: Link libgit2 via LIB_FUZZING_ENGINE

Author: Paulo Gomes

tests/fuzz/oss_fuzz_postbuild.sh

@@ -20,10 +20,14 @@ set -euxo pipefail
 # Use it for unsetting any environment variables that may impact other building
 # processes.
 
+if [[ -n "${PRE_LIB_FUZZING_ENGINE}" ]]; then
+	export LIB_FUZZING_ENGINE="${PRE_LIB_FUZZING_ENGINE}"
+fi
+
 unset TARGET_DIR
 unset CGO_ENABLED
 unset LIBRARY_PATH
 unset PKG_CONFIG_PATH
 unset CGO_CFLAGS
 unset CGO_LDFLAGS
-unset ADDITIONAL_LIBS
+unset PRE_LIB_FUZZING_ENGINE

tests/fuzz/oss_fuzz_prebuild.sh

@@ -62,4 +62,15 @@ export PKG_CONFIG_PATH="${TARGET_DIR}/lib/pkgconfig"
 export CGO_CFLAGS="-I${TARGET_DIR}/include"
 export CGO_LDFLAGS="$(pkg-config --libs --static --cflags libgit2)"
 
-export ADDITIONAL_LIBS="${TARGET_DIR}/lib/libgit2.a"
+# Temporary hack whilst libgit2 is still in use.
+# Enables the fuzzing compilation to link libgit2.
+#
+# After building the fuzzers, the value of
+# LIB_FUZZING_ENGINE is reset to what it was before
+# it to avoid side effects onto other repositories.
+#
+# For context refer to:
+# https://github.com/google/oss-fuzz/pull/9063
+export PRE_LIB_FUZZING_ENGINE="${LIB_FUZZING_ENGINE}"
+
+export LIB_FUZZING_ENGINE="${LIB_FUZZING_ENGINE} -Wl,--start-group ${TARGET_DIR}/lib/libgit2.a"