testserver: move from internal to pkg

Author: hiddeco

controllers/gitrepository_controller_test.go

@@ -39,7 +39,7 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 
 	sourcev1 "github.com/fluxcd/source-controller/api/v1alpha1"
-	"github.com/fluxcd/source-controller/internal/testserver"
+	"github.com/fluxcd/source-controller/pkg/testserver"
 )
 
 var _ = Describe("GitRepositoryReconciler", func() {

controllers/helmchart_controller_test.go

@@ -31,7 +31,7 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 
 	sourcev1 "github.com/fluxcd/source-controller/api/v1alpha1"
-	"github.com/fluxcd/source-controller/internal/testserver"
+	"github.com/fluxcd/source-controller/pkg/testserver"
 )
 
 var _ = Describe("HelmChartReconciler", func() {

controllers/helmrepository_controller_test.go

@@ -31,7 +31,7 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 
 	sourcev1 "github.com/fluxcd/source-controller/api/v1alpha1"
-	"github.com/fluxcd/source-controller/internal/testserver"
+	"github.com/fluxcd/source-controller/pkg/testserver"
 )
 
 var _ = Describe("HelmRepositoryReconciler", func() {

internal/testserver/artifact.go pkg/testserver/artifact.gointernal/testserver/artifact.go renamed to pkg/testserver/artifact.go

@@ -62,23 +62,23 @@ func (s *ArtifactServer) ArtifactFromBytes(files []File) (string, error) {
 	tw := tar.NewWriter(gw)
 	defer tw.Close()
 
-	for _, file := range files {
+	for _, f := range files {
 		hdr := &tar.Header{
-			Name: file.Name,
+			Name: f.Name,
 			Mode: 0600,
-			Size: int64(len(file.Body)),
+			Size: int64(len(f.Body)),
 		}
 		if err := tw.WriteHeader(hdr); err != nil {
 			return "", err
 		}
-		if _, err := tw.Write([]byte(file.Body)); err != nil {
+		if _, err := tw.Write([]byte(f.Body)); err != nil {
 			return "", err
 		}
 	}
 	return fileName, nil
 }
 
-// URLForFile returns the URL the given file path can be reached at or
+// URLForFile returns the URL the given file can be reached at or
 // an error if the server has not been started.
 func (s *ArtifactServer) URLForFile(file string) (string, error) {
 	if s.URL() == "" {