Skip to content

Commit 15d2452

Browse files
stefanprodanmatheuscscp
authored andcommitted
Adapt tests to Helm v3.18.0 JSON number
Signed-off-by: Stefan Prodan <[email protected]>
1 parent a5cf14e commit 15d2452

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

internal/helm/chart/builder_local_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package chart
1818

1919
import (
2020
"context"
21+
"encoding/json"
2122
"os"
2223
"path/filepath"
2324
"sync"
@@ -112,7 +113,7 @@ func TestLocalBuilder_Build(t *testing.T) {
112113
name: "default values",
113114
reference: LocalReference{Path: "../testdata/charts/helmchart"},
114115
wantValues: chartutil.Values{
115-
"replicaCount": float64(1),
116+
"replicaCount": json.Number("1"),
116117
},
117118
wantVersion: "0.1.0",
118119
wantPackaged: true,
@@ -136,7 +137,7 @@ fullnameOverride: "full-foo-name-override"`),
136137
},
137138
},
138139
wantValues: chartutil.Values{
139-
"replicaCount": float64(20),
140+
"replicaCount": json.Number("20"),
140141
"nameOverride": "foo-name-override",
141142
"fullnameOverride": "full-foo-name-override",
142143
},
@@ -157,7 +158,7 @@ fullnameOverride: "full-foo-name-override"`),
157158
name: "v1 chart",
158159
reference: LocalReference{Path: "./../testdata/charts/helmchart-v1"},
159160
wantValues: chartutil.Values{
160-
"replicaCount": float64(1),
161+
"replicaCount": json.Number("1"),
161162
},
162163
wantVersion: "0.2.0",
163164
wantPackaged: true,

internal/helm/chart/builder_remote_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package chart
1919
import (
2020
"bytes"
2121
"context"
22+
"encoding/json"
2223
"fmt"
2324
"net/url"
2425
"os"
@@ -168,7 +169,7 @@ entries:
168169
repository: mockRepo(),
169170
wantVersion: "0.1.0",
170171
wantValues: chartutil.Values{
171-
"replicaCount": float64(1),
172+
"replicaCount": json.Number("1"),
172173
},
173174
},
174175
{
@@ -316,7 +317,7 @@ func TestRemoteBuilder_BuildFromOCIChartRepository(t *testing.T) {
316317
repository: mockRepo(),
317318
wantVersion: "0.1.0",
318319
wantValues: chartutil.Values{
319-
"replicaCount": float64(1),
320+
"replicaCount": json.Number("1"),
320321
},
321322
},
322323
{
@@ -325,7 +326,7 @@ func TestRemoteBuilder_BuildFromOCIChartRepository(t *testing.T) {
325326
repository: mockRepo(),
326327
wantVersion: "0.1.0",
327328
wantValues: chartutil.Values{
328-
"replicaCount": float64(1),
329+
"replicaCount": json.Number("1"),
329330
},
330331
},
331332
{

0 commit comments

Comments
 (0)