internal/helm: ensure err is checked before defer

hiddeco · hiddeco · commit 16d4a4899bf9 · 2021-11-23T09:51:44.000+01:00
Signed-off-by: Hidde Beydals &lt;hello@hidde.co&gt;
diff --git a/internal/helm/chart/builder_remote_test.go b/internal/helm/chart/builder_remote_test.go
@@ -357,8 +357,8 @@ func Test_validatePackageAndWriteToPath(t *testing.T) {
 	g.Expect(chartPath).To(BeARegularFile())
 
 	emptyF, err := os.Open("./../testdata/charts/empty.tgz")
-	defer emptyF.Close()
 	g.Expect(err).ToNot(HaveOccurred())
+	defer emptyF.Close()
 	err = validatePackageAndWriteToPath(emptyF, filepath.Join(tmpDir, "out.tgz"))
 	g.Expect(err).To(HaveOccurred())
 }

Original file line number	Diff line number	Diff line change
`@@ -357,8 +357,8 @@ func Test_validatePackageAndWriteToPath(t *testing.T) {`
`357`	`357`	`g.Expect(chartPath).To(BeARegularFile())`
`358`	`358`
`359`	`359`	`emptyF, err := os.Open("./../testdata/charts/empty.tgz")`
`360`		`- defer emptyF.Close()`
`361`	`360`	`g.Expect(err).ToNot(HaveOccurred())`
	`361`	`+ defer emptyF.Close()`
`362`	`362`	`err = validatePackageAndWriteToPath(emptyF, filepath.Join(tmpDir, "out.tgz"))`
`363`	`363`	`g.Expect(err).To(HaveOccurred())`
`364`	`364`	`}`