Tests for GCP Bucket Provider

Signed-off-by: pa250194 <[email protected]>

Author: pa250194

docs/spec/v1alpha1/buckets.md

@@ -11,7 +11,7 @@ Bucket:
 // BucketSpec defines the desired state of an S3 compatible bucket
 type BucketSpec struct {
 	// The S3 compatible storage provider name, default ('generic').
-	// +kubebuilder:validation:Enum=generic;aws
+	// +kubebuilder:validation:Enum=generic;aws;gcp
 	// +optional
 	Provider string `json:"provider,omitempty"`
 

pkg/gcp/gcp.go

@@ -55,8 +55,6 @@ type Client interface {
 }
 
 type BucketHandle interface {
-	Create(context.Context, string, *gcpStorage.BucketAttrs) error
-	Delete(context.Context) error
 	Attrs(context.Context) (*gcpStorage.BucketAttrs, error)
 	Object(string) *gcpStorage.ObjectHandle
 	Objects(context.Context, *gcpStorage.Query) *gcpStorage.ObjectIterator
@@ -66,10 +64,11 @@ type ObjectHandle interface {
 	Attrs(context.Context) (*gcpStorage.ObjectAttrs, error)
 	NewRangeReader(context.Context, int64, int64) (*gcpStorage.Reader, error)
 }
+
 type GCPClient struct {
 	// client for interacting with the Google Cloud
 	// Storage APIs.
-	Client Client
+	Client
 	// startRange is the starting read value for
 	// reading the object from bucket.
 	StartRange int64
@@ -165,9 +164,6 @@ func ValidateSecret(secret map[string][]byte, name string) error {
 	if _, exists := secret["clientemail"]; !exists {
 		return fmt.Errorf("invalid '%s' secret data: required fields 'clientemail'", name)
 	}
-	if _, exists := secret["clientemail"]; !exists {
-		return fmt.Errorf("invalid '%s' secret data: required fields 'clientemail'", name)
-	}
 	if _, exists := secret["clientid"]; !exists {
 		return fmt.Errorf("invalid '%s' secret data: required fields 'clientid'", name)
 	}

pkg/gcp/gcp_test.go

@@ -57,7 +57,7 @@ var _ = BeforeSuite(func() {
 		Expect(err).ToNot(HaveOccurred())
 	}
 	localPath = filepath.Join(tempDir, objectName)
-	MockClient.EXPECT().Bucket(bucketName).Return(MockBucketHandle).AnyTimes()
+	MockClient.EXPECT().Bucket(bucketName).Return(&gcpStorage.BucketHandle{}).AnyTimes()
 	MockBucketHandle.EXPECT().Object(objectName).Return(&gcpStorage.ObjectHandle{}).AnyTimes()
 	MockBucketHandle.EXPECT().Attrs(context.Background()).Return(&gcpStorage.BucketAttrs{
 		Name:    bucketName,