helm: Skip setting TLSLoginOption

stefanprodan · stefanprodan · commit 2b87ef7d7a4a · 2025-10-02T22:52:24.000+03:00
Signed-off-by: Stefan Prodan &lt;stefan.prodan@gmail.com&gt;
diff --git a/internal/helm/getter/client_opts.go b/internal/helm/getter/client_opts.go
@@ -215,15 +215,15 @@ func configureOCIRegistryWithSecrets(ctx context.Context, obj *sourcev1.HelmRepo
 			tlsSecret = authSecret
 		}
 
-		certFile, keyFile, caFile, err := storeTLSCertificateFilesForOCI(ctx, tlsSecret, nil, tempCertDir)
+		_, _, _, err := storeTLSCertificateFilesForOCI(ctx, tlsSecret, nil, tempCertDir)
 		if err != nil {
 			return "", fmt.Errorf("cannot write certs files to path: %w", err)
 		}
 
-		tlsLoginOpt := registry.TLSLoginOption(certFile, keyFile, caFile)
-		if tlsLoginOpt != nil {
-			opts.RegLoginOpts = append(opts.RegLoginOpts, tlsLoginOpt)
-		}
+		//tlsLoginOpt := registry.TLSLoginOption(certFile, keyFile, caFile)
+		//if tlsLoginOpt != nil {
+		//	opts.RegLoginOpts = append(opts.RegLoginOpts, tlsLoginOpt)
+		//}
 	}
 
 	return tempCertDir, nil

Original file line number	Diff line number	Diff line change
`@@ -215,15 +215,15 @@ func configureOCIRegistryWithSecrets(ctx context.Context, obj *sourcev1.HelmRepo`
`215`	`215`	`tlsSecret = authSecret`
`216`	`216`	`}`
`217`	`217`
`218`		`- certFile, keyFile, caFile, err := storeTLSCertificateFilesForOCI(ctx, tlsSecret, nil, tempCertDir)`
	`218`	`+ _, _, _, err := storeTLSCertificateFilesForOCI(ctx, tlsSecret, nil, tempCertDir)`
`219`	`219`	`if err != nil {`
`220`	`220`	`return "", fmt.Errorf("cannot write certs files to path: %w", err)`
`221`	`221`	`}`
`222`	`222`
`223`		`- tlsLoginOpt := registry.TLSLoginOption(certFile, keyFile, caFile)`
`224`		`- if tlsLoginOpt != nil {`
`225`		`- opts.RegLoginOpts = append(opts.RegLoginOpts, tlsLoginOpt)`
`226`		`- }`
	`223`	`+ //tlsLoginOpt := registry.TLSLoginOption(certFile, keyFile, caFile)`
	`224`	`+ //if tlsLoginOpt != nil {`
	`225`	`+ // opts.RegLoginOpts = append(opts.RegLoginOpts, tlsLoginOpt)`
	`226`	`+ //}`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`return tempCertDir, nil`