controllers: check GitRepository reference != nil

hiddeco · hiddeco · commit 2c0b1758074c · 2020-04-29T16:45:25.000+02:00
To prevent the reconciler from panicing when no reference is
configured for the GitRepository.
diff --git a/controllers/gitrepository_controller.go b/controllers/gitrepository_controller.go
@@ -321,7 +321,7 @@ func (r *GitRepositoryReconciler) sync(ctx context.Context, repository sourcev1.
 
 	if revision == "" {
 		revision = fmt.Sprintf("%s/%s", branch, ref.Hash().String())
-		if repository.Spec.Reference.Tag != "" {
+		if repository.Spec.Reference != nil && repository.Spec.Reference.Tag != "" {
 			revision = fmt.Sprintf("%s/%s", repository.Spec.Reference.Tag, ref.Hash().String())
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ func (r *GitRepositoryReconciler) sync(ctx context.Context, repository sourcev1.`
`321`	`321`
`322`	`322`	`if revision == "" {`
`323`	`323`	`revision = fmt.Sprintf("%s/%s", branch, ref.Hash().String())`
`324`		`- if repository.Spec.Reference.Tag != "" {`
	`324`	`+ if repository.Spec.Reference != nil && repository.Spec.Reference.Tag != "" {`
`325`	`325`	`revision = fmt.Sprintf("%s/%s", repository.Spec.Reference.Tag, ref.Hash().String())`
`326`	`326`	`}`
`327`	`327`	`}`