Skip to content

Commit 37e602a

Browse files
committed
Address review nitpicks
- Use octal syntax for permissions. - Fix typo. Signed-off-by: Hidde Beydals <[email protected]>
1 parent d55a759 commit 37e602a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/azure/blob.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ func (c *BlobClient) FGetObject(ctx context.Context, bucketName, objectName, loc
192192
objectDir, _ := filepath.Split(localPath)
193193
if objectDir != "" {
194194
// Create any missing top level directories.
195-
if err := os.MkdirAll(objectDir, 0700); err != nil {
195+
if err := os.MkdirAll(objectDir, 0o700); err != nil {
196196
return "", err
197197
}
198198
}
@@ -204,7 +204,7 @@ func (c *BlobClient) FGetObject(ctx context.Context, bucketName, objectName, loc
204204
}
205205

206206
// Prepare target file.
207-
f, err := os.OpenFile(localPath, os.O_CREATE|os.O_WRONLY, 0600)
207+
f, err := os.OpenFile(localPath, os.O_CREATE|os.O_WRONLY, 0o600)
208208
if err != nil {
209209
return "", err
210210
}

pkg/azure/blob_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func TestValidateSecret(t *testing.T) {
4949
},
5050
},
5151
{
52-
name: "valid UserManagerIdentity Secret",
52+
name: "valid UserManagedIdentity Secret",
5353
secret: &corev1.Secret{
5454
Data: map[string][]byte{
5555
clientIDField: []byte("some-client-id-"),

0 commit comments

Comments
 (0)