Skip to content

Commit 440c70d

Browse files
stefanprodanhiddeco
andcommitted
Fix public key naming
Co-Authored-By: Hidde Beydals <[email protected]>
1 parent 96e289f commit 440c70d

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

api/v1alpha1/gitrepository_types.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type GitRepositorySpec struct {
4545
// +optional
4646
Reference *GitRepositoryRef `json:"ref,omitempty"`
4747

48-
// Verify PGP signature for the commit that HEAD points to.
48+
// Verify OpenPGP signature for the commit that HEAD points to.
4949
// +optional
5050
Verification *GitRepositoryVerification `json:"verify,omitempty"`
5151
}
@@ -70,18 +70,17 @@ type GitRepositoryRef struct {
7070
Commit string `json:"commit"`
7171
}
7272

73-
// GitRepositoryStatus defines the observed state of the GitRepository.
74-
// GitRepositoryVerification defines the GPG signature verification process
73+
// GitRepositoryVerification defines the OpenPGP signature verification process.
7574
type GitRepositoryVerification struct {
76-
// Mode describes what git object should be verified.
75+
// Mode describes what git object should be verified, currently ('head').
7776
// +kubebuilder:validation:Enum=head
7877
Mode string `json:"mode"`
7978

8079
// The secret name containing the public keys of all trusted git authors.
8180
SecretRef corev1.LocalObjectReference `json:"secretRef,omitempty"`
8281
}
8382

84-
// GitRepositoryStatus defines the observed state of GitRepository
83+
// GitRepositoryStatus defines the observed state of Git repository.
8584
type GitRepositoryStatus struct {
8685
// +optional
8786
Conditions []SourceCondition `json:"conditions,omitempty"`

controllers/gitrepository_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ func (r *GitRepositoryReconciler) sync(ctx context.Context, repository sourcev1.
282282
var secret corev1.Secret
283283
err = r.Client.Get(ctx, name, &secret)
284284
if err != nil {
285-
err = fmt.Errorf("GPG public keys secret error: %w", err)
285+
err = fmt.Errorf("PGP public keys secret error: %w", err)
286286
return sourcev1.GitRepositoryNotReady(repository, sourcev1.GitOperationFailedReason, err.Error()), err
287287
}
288288

0 commit comments

Comments
 (0)