helmrepo: only log recovery msg on actual recovery

hiddeco · hiddeco · commit 76c4bb78bdca · 2023-02-22T23:35:21.000+01:00
Signed-off-by: Hidde Beydals &lt;hello@hidde.co&gt;
diff --git a/controllers/helmrepository_controller.go b/controllers/helmrepository_controller.go
@@ -318,8 +318,8 @@ func (r *HelmRepositoryReconciler) notify(ctx context.Context, oldObj, newObj *s
 			if sreconcile.FailureRecovery(oldObj, newObj, helmRepositoryFailConditions) {
 				r.AnnotatedEventf(newObj, annotations, corev1.EventTypeNormal,
 					meta.SucceededReason, message)
+				ctrl.LoggerFrom(ctx).Info(message)
 			}
-			ctrl.LoggerFrom(ctx).Info(message)
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -318,8 +318,8 @@ func (r HelmRepositoryReconciler) notify(ctx context.Context, oldObj, newObj s`
`318`	`318`	`if sreconcile.FailureRecovery(oldObj, newObj, helmRepositoryFailConditions) {`
`319`	`319`	`r.AnnotatedEventf(newObj, annotations, corev1.EventTypeNormal,`
`320`	`320`	`meta.SucceededReason, message)`
	`321`	`+ ctrl.LoggerFrom(ctx).Info(message)`
`321`	`322`	`}`
`322`		`- ctrl.LoggerFrom(ctx).Info(message)`
`323`	`323`	`}`
`324`	`324`	`}`
`325`	`325`	`}`