Skip to content

Commit 7abe759

Browse files
author
Paulo Gomes
committed
Add make verify
Signed-off-by: Paulo Gomes <[email protected]>
1 parent 0c9078c commit 7abe759

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

.github/workflows/e2e.yaml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,8 @@ jobs:
3737
uses: ./.github/actions/run-tests
3838
env:
3939
GOPATH: /github/home/go
40-
- name: Check if working tree is dirty
41-
run: |
42-
if [[ $(git diff --stat) != '' ]]; then
43-
git --no-pager diff
44-
echo 'run make test and commit changes'
45-
exit 1
46-
fi
40+
- name: Verify
41+
run: make verify
4742
- name: Run E2E tests
4843
env:
4944
CREATE_CLUSTER: false

Makefile

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,3 +228,12 @@ update-attributions:
228228

229229
e2e:
230230
./hack/ci/e2e.sh
231+
232+
verify: update-attributions fmt vet
233+
ifneq (, $(shell git status --porcelain --untracked-files=no))
234+
@{ \
235+
echo "working directory is dirty:"; \
236+
git --no-pager diff; \
237+
exit 1; \
238+
}
239+
endif

hack/ci/e2e.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ kubectl -n source-system delete -f "${ROOT_DIR}/config/testdata/helmchart-values
8181

8282
echo "Setup Minio"
8383
kubectl create ns minio
84-
helm repo add minio https://helm.min.io/
84+
helm repo add minio https://helm.min.io/ --force-update
8585
helm upgrade minio minio/minio --wait -i \
8686
--version "${MINIO_HELM_VER}" \
8787
--namespace minio \

0 commit comments

Comments
 (0)