helm/repository: address invalid test

Common mistake
(https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables),
but due to update now properly found by `go vet`.

In addition to making the test cases work in general.

Signed-off-by: Hidde Beydals <[email protected]>

Author: hiddeco

internal/helm/repository/oci_chart_repository_test.go

@@ -210,7 +210,6 @@ func TestOCIChartRepository_Get(t *testing.T) {
 }
 
 func TestOCIChartRepository_DownloadChart(t *testing.T) {
-	client := &mockRegistryClient{}
 	testCases := []struct {
 		name         string
 		url          string
@@ -225,7 +224,7 @@ func TestOCIChartRepository_DownloadChart(t *testing.T) {
 				Metadata: &chart.Metadata{Name: "chart"},
 				URLs:     []string{"oci://localhost:5000/my_repo/podinfo:1.0.0"},
 			},
-			expected: "oci://localhost:5000/my_repo/podinfo:1.0.0",
+			expected: "localhost:5000/my_repo/podinfo:1.0.0",
 		},
 		{
 			name:         "no chart URL",
@@ -245,27 +244,29 @@ func TestOCIChartRepository_DownloadChart(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
+		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
-			g := NewWithT(t)
 			t.Parallel()
-			mg := OCIMockGetter{}
+
+			g := NewWithT(t)
+
 			u, err := url.Parse(tc.url)
 			g.Expect(err).ToNot(HaveOccurred())
+
+			mg := OCIMockGetter{}
 			r := OCIChartRepository{
 				Client: &mg,
 				URL:    *u,
 			}
-			r.Client = &mg
-			g.Expect(err).ToNot(HaveOccurred())
-			g.Expect(r).ToNot(BeNil())
+
 			res, err := r.DownloadChart(tc.chartVersion)
 			if tc.expectedErr {
 				g.Expect(err).To(HaveOccurred())
 				return
 			}
 
 			g.Expect(err).ToNot(HaveOccurred())
-			g.Expect(client.LastCalledURL).To(Equal(tc.expected))
+			g.Expect(mg.LastCalledURL).To(Equal(tc.expected))
 			g.Expect(res).ToNot(BeNil())
 			g.Expect(err).ToNot(HaveOccurred())
 		})