Prioritize StorageOperationFailedCondition

Prioritize StorageOperationFailedCondition over other artifact outdated
and unavailable conditions so that when artifact is failing due to
storage operation, it's visble in the ready status condition, making the
reason for not ready more accurate.

Signed-off-by: Sunny <[email protected]>

Author: darkowlzz

controllers/bucket_controller.go

@@ -75,23 +75,23 @@ var bucketReadyCondition = summarize.Conditions{
 	Target: meta.ReadyCondition,
 	Owned: []string{
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.ReadyCondition,
 		meta.ReconcilingCondition,
 		meta.StalledCondition,
 	},
 	Summarize: []string{
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.StalledCondition,
 		meta.ReconcilingCondition,
 	},
 	NegativePolarity: []string{
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.StalledCondition,
 		meta.ReconcilingCondition,
 	},

controllers/gitrepository_controller.go

@@ -62,9 +62,9 @@ var gitRepositoryReadyCondition = summarize.Conditions{
 	Owned: []string{
 		sourcev1.SourceVerifiedCondition,
 		sourcev1.FetchFailedCondition,
+		sourcev1.StorageOperationFailedCondition,
 		sourcev1.IncludeUnavailableCondition,
 		sourcev1.ArtifactOutdatedCondition,
-		sourcev1.StorageOperationFailedCondition,
 		meta.ReadyCondition,
 		meta.ReconcilingCondition,
 		meta.StalledCondition,
@@ -73,16 +73,16 @@ var gitRepositoryReadyCondition = summarize.Conditions{
 		sourcev1.IncludeUnavailableCondition,
 		sourcev1.SourceVerifiedCondition,
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.StalledCondition,
 		meta.ReconcilingCondition,
 	},
 	NegativePolarity: []string{
 		sourcev1.FetchFailedCondition,
 		sourcev1.IncludeUnavailableCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.StalledCondition,
 		meta.ReconcilingCondition,
 	},

controllers/helmchart_controller.go

@@ -71,25 +71,25 @@ var helmChartReadyCondition = summarize.Conditions{
 	Owned: []string{
 		sourcev1.BuildFailedCondition,
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.ReadyCondition,
 		meta.ReconcilingCondition,
 		meta.StalledCondition,
 	},
 	Summarize: []string{
 		sourcev1.BuildFailedCondition,
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.StalledCondition,
 		meta.ReconcilingCondition,
 	},
 	NegativePolarity: []string{
 		sourcev1.BuildFailedCondition,
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.StalledCondition,
 		meta.ReconcilingCondition,
 	},

controllers/helmrepository_controller.go

@@ -58,23 +58,23 @@ var helmRepositoryReadyCondition = summarize.Conditions{
 	Target: meta.ReadyCondition,
 	Owned: []string{
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.ReadyCondition,
 		meta.ReconcilingCondition,
 		meta.StalledCondition,
 	},
 	Summarize: []string{
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.StalledCondition,
 		meta.ReconcilingCondition,
 	},
 	NegativePolarity: []string{
 		sourcev1.FetchFailedCondition,
-		sourcev1.ArtifactOutdatedCondition,
 		sourcev1.StorageOperationFailedCondition,
+		sourcev1.ArtifactOutdatedCondition,
 		meta.StalledCondition,
 		meta.ReconcilingCondition,
 	},