git: Replace Stalling error for git implementation

Paulo Gomes · Paulo Gomes · commit bdcf708ef8da · 2022-11-11T10:25:01.000Z
Signed-off-by: Paulo Gomes &lt;paulo.gomes@weave.works&gt;
diff --git a/controllers/gitrepository_controller.go b/controllers/gitrepository_controller.go
@@ -768,8 +768,7 @@ func (r *GitRepositoryReconciler) gitCheckout(ctx context.Context,
 		err = fmt.Errorf("invalid Git implementation: %s", gitImplementation)
 	}
 	if err != nil {
-		// Do not return err as recovery without changes is impossible.
-		e := serror.NewStalling(
+		e := serror.NewGeneric(
 			fmt.Errorf("failed to create Git client for implementation '%s': %w", gitImplementation, err),
 			sourcev1.GitOperationFailedReason,
 		)

Original file line number	Diff line number	Diff line change
`@@ -768,8 +768,7 @@ func (r *GitRepositoryReconciler) gitCheckout(ctx context.Context,`
`768`	`768`	`err = fmt.Errorf("invalid Git implementation: %s", gitImplementation)`
`769`	`769`	`}`
`770`	`770`	`if err != nil {`
`771`		`- // Do not return err as recovery without changes is impossible.`
`772`		`- e := serror.NewStalling(`
	`771`	`+ e := serror.NewGeneric(`
`773`	`772`	`fmt.Errorf("failed to create Git client for implementation '%s': %w", gitImplementation, err),`
`774`	`773`	`sourcev1.GitOperationFailedReason,`
`775`	`774`	`)`