git/ssh: use in-memory known hosts database

Author: hiddeco

controllers/gitrepository_controller.go

@@ -163,14 +163,11 @@ func (r *GitRepositoryReconciler) sync(ctx context.Context, repository sourcev1.
 			return sourcev1.GitRepositoryNotReady(repository, sourcev1.AuthenticationFailedReason, err.Error()), err
 		}
 
-		method, cleanup, err := intgit.AuthMethodFromSecret(repository.Spec.URL, secret)
+		method, err := intgit.AuthMethodFromSecret(repository.Spec.URL, secret)
 		if err != nil {
 			err = fmt.Errorf("auth error: %w", err)
 			return sourcev1.GitRepositoryNotReady(repository, sourcev1.AuthenticationFailedReason, err.Error()), err
 		}
-		if cleanup != nil {
-			defer cleanup()
-		}
 		auth = method
 	}
 
@@ -292,7 +289,7 @@ func (r *GitRepositoryReconciler) sync(ctx context.Context, repository sourcev1.
 	if repository.Spec.Verification != nil {
 		err := r.verify(ctx, types.NamespacedName{
 			Namespace: repository.Namespace,
-			Name: repository.Spec.Verification.SecretRef.Name,
+			Name:      repository.Spec.Verification.SecretRef.Name,
 		}, commit)
 		if err != nil {
 			return sourcev1.GitRepositoryNotReady(repository, sourcev1.VerificationFailedReason, err.Error()), err

go.mod

@@ -8,7 +8,7 @@ require (
 	github.com/go-logr/logr v0.1.0
 	github.com/onsi/ginkgo v1.11.0
 	github.com/onsi/gomega v1.8.1
-	github.com/pkg/errors v0.9.1
+	golang.org/x/crypto v0.0.0-20200302210943-78000ba7a073
 	helm.sh/helm/v3 v3.1.2
 	k8s.io/api v0.17.2
 	k8s.io/apimachinery v0.17.2