Skip to content

Commit d227586

Browse files
committed
oci-helmrepo: handle conditions summary in-line
Refactor the OCI HelmRepo reconciler to remove extra custom status conditions and manage Ready, Reconciling and Stalled conditions within the reconciler, in-line. The internal/reconcile/summarize package uses the patch helper conditions summary before patching which results in overwriting the Ready condition with Reconciling condition as it's a negative polarity condition. For OCI HelmRepository, since it's a simple reconciler, it'd be better to not introduce extra conditions and utilize the three base conditions to represent the status. In order to have the same consistent status conditions, a new summarization is written within the reconciler based on the context. It takes into consideration a lot of the details from the internal/reconcile/summarize package and handles certain scenarios in context specific ways. All the result and error abstractions are removed since they are only needed when using internal/reconcile package. Signed-off-by: Sunny <[email protected]>
1 parent 9d6eada commit d227586

File tree

2 files changed

+162
-169
lines changed

2 files changed

+162
-169
lines changed

0 commit comments

Comments
 (0)