Skip to content

Commit ec05e0e

Browse files
authored
Merge pull request #280 from runyontr/runyontr-279
Properly escape outer loop for present dependency
2 parents eca08f8 + 8428054 commit ec05e0e

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

controllers/helmchart_controller.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,11 +539,15 @@ func (r *HelmChartReconciler) reconcileFromTarballArtifact(ctx context.Context,
539539
var dwr []*helm.DependencyWithRepository
540540
for _, dep := range reqs {
541541
// Exclude existing dependencies
542+
found := false
542543
for _, existing := range deps {
543544
if existing.Name() == dep.Name {
544-
continue
545+
found = true
545546
}
546547
}
548+
if found {
549+
continue
550+
}
547551

548552
// Continue loop if file scheme detected
549553
if dep.Repository == "" || strings.HasPrefix(dep.Repository, "file://") {

0 commit comments

Comments
 (0)