Skip to content

Commit ef9dbd1

Browse files
zhiyu0729github-actions[bot]
authored andcommitted
Chore: use auto bucket lookup type
Signed-off-by: Zhiyu Wang <[email protected]> (cherry picked from commit 1ab089e)
1 parent 5d68b5d commit ef9dbd1

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

pkg/minio/minio.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,11 @@ type MinioClient struct {
3838
// NewClient creates a new Minio storage client.
3939
func NewClient(bucket *sourcev1.Bucket, secret *corev1.Secret) (*MinioClient, error) {
4040
opt := minio.Options{
41-
Region: bucket.Spec.Region,
42-
Secure: !bucket.Spec.Insecure,
43-
BucketLookup: minio.BucketLookupPath,
41+
Region: bucket.Spec.Region,
42+
Secure: !bucket.Spec.Insecure,
43+
// About BucketLookup, it should be noted that not all S3 providers support
44+
// path-type access (e.g., Ali OSS). Hence, we revert to using the default
45+
// auto access, which we believe can cover most use cases.
4446
}
4547

4648
if secret != nil {

0 commit comments

Comments
 (0)