Skip to content

Commit fa00ec8

Browse files
author
Paulo Gomes
committed
Migrate from deprecated ginkgo async testing
https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md\#removed-async-testing Signed-off-by: Paulo Gomes <[email protected]>
1 parent 21e71c3 commit fa00ec8

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

controllers/suite_test.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ var exampleCA []byte
5656
var ctx context.Context
5757
var cancel context.CancelFunc
5858

59+
const timeout = time.Second * 30
60+
5961
func TestAPIs(t *testing.T) {
6062
RegisterFailHandler(Fail)
6163

@@ -64,7 +66,12 @@ func TestAPIs(t *testing.T) {
6466
[]Reporter{printer.NewlineReporter{}})
6567
}
6668

67-
var _ = BeforeSuite(func(done Done) {
69+
var _ = BeforeSuite(func() {
70+
done := make(chan interface{})
71+
go func() {
72+
close(done)
73+
}()
74+
6875
logf.SetLogger(
6976
zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)),
7077
)
@@ -153,7 +160,7 @@ var _ = BeforeSuite(func(done Done) {
153160
k8sClient = k8sManager.GetClient()
154161
Expect(k8sClient).ToNot(BeNil())
155162

156-
close(done)
163+
Eventually(done, timeout).Should(BeClosed())
157164
}, 60)
158165

159166
var _ = AfterSuite(func() {

0 commit comments

Comments
 (0)