Skip to content

Commit 75e9d58

Browse files
committed
change compose.yml to RAILS_MASTER_KEY
1 parent 2ddc134 commit 75e9d58

File tree

13 files changed

+51
-56
lines changed

13 files changed

+51
-56
lines changed

lib/generators/templates/docker-compose.yml.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ services:
4040
<% end -%>
4141
<% end -%>
4242
secrets:
43-
- source: master_key
43+
- source: RAILS_MASTER_KEY
4444
target: /rails/config/master.key
4545
<% if using_redis? or deploy_database != 'sqlite3' -%>
4646
depends_on:
@@ -135,5 +135,5 @@ secrets:
135135
<% end -%>
136136

137137
secrets:
138-
master_key:
139-
file: ./config/master.key
138+
RAILS_MASTER_KEY
139+
file: ./config/master.key

test/results/api/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ services:
1414
- "3000:3000"
1515
environment:
1616
secrets:
17-
- source: master_key
17+
- source: RAILS_MASTER_KEY
1818
target: /rails/config/master.key
1919

2020
secrets:
21-
master_key:
22-
file: ./config/master.key
21+
RAILS_MASTER_KEY
22+
file: ./config/master.key

test/results/bun/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ services:
1414
- "3000:3000"
1515
environment:
1616
secrets:
17-
- source: master_key
17+
- source: RAILS_MASTER_KEY
1818
target: /rails/config/master.key
1919

2020
secrets:
21-
master_key:
22-
file: ./config/master.key
21+
RAILS_MASTER_KEY
22+
file: ./config/master.key

test/results/esbuild/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ services:
1414
- "3000:3000"
1515
environment:
1616
secrets:
17-
- source: master_key
17+
- source: RAILS_MASTER_KEY
1818
target: /rails/config/master.key
1919

2020
secrets:
21-
master_key:
22-
file: ./config/master.key
21+
RAILS_MASTER_KEY
22+
file: ./config/master.key

test/results/mysql/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ services:
1515
environment:
1616
- DATABASE_URL=mysql2://root:password@mysql-db/
1717
secrets:
18-
- source: master_key
18+
- source: RAILS_MASTER_KEY
1919
target: /rails/config/master.key
2020
depends_on:
2121
mysql-db:
@@ -36,5 +36,5 @@ services:
3636
retries: 30
3737

3838
secrets:
39-
master_key:
40-
file: ./config/master.key
39+
RAILS_MASTER_KEY
40+
file: ./config/master.key

test/results/postgresql/Dockerfile

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,44 +2,40 @@
22
# check=error=true
33

44
# This Dockerfile is designed for production, not development. Use with Kamal or build'n'run by hand:
5-
# docker build -t demo .
6-
# docker run -d -p 80:80 -e RAILS_MASTER_KEY=<value from config/master.key> --name demo demo
5+
# docker build -t test_postgresql .
6+
# docker run -d -p 80:80 -e RAILS_MASTER_KEY=<value from config/master.key> --name test_postgresql test_postgresql
77

88
# For a containerized dev environment, see Dev Containers: https://guides.rubyonrails.org/getting_started_with_devcontainer.html
99

1010
# Make sure RUBY_VERSION matches the Ruby version in .ruby-version
1111
ARG RUBY_VERSION=xxx
12-
FROM ruby:$RUBY_VERSION-slim AS base
12+
FROM docker.io/library/ruby:$RUBY_VERSION-slim AS base
1313

1414
# Rails app lives here
1515
WORKDIR /rails
1616

17-
# Update gems and bundler
18-
RUN gem update --system --no-document && \
19-
gem install -N bundler
20-
2117
# Install base packages
2218
RUN apt-get update -qq && \
23-
apt-get install --no-install-recommends -y curl libjemalloc2 postgresql-client && \
19+
apt-get install --no-install-recommends -y curl libjemalloc2 libvips postgresql-client && \
2420
rm -rf /var/lib/apt/lists /var/cache/apt/archives
2521

2622
# Set production environment
27-
ENV BUNDLE_DEPLOYMENT="1" \
23+
ENV RAILS_ENV="production" \
24+
BUNDLE_DEPLOYMENT="1" \
2825
BUNDLE_PATH="/usr/local/bundle" \
29-
BUNDLE_WITHOUT="development:test" \
30-
RAILS_ENV="production"
31-
26+
BUNDLE_WITHOUT="development"
3227

3328
# Throw-away build stage to reduce size of final image
3429
FROM base AS build
3530

3631
# Install packages needed to build gems
3732
RUN apt-get update -qq && \
38-
apt-get install --no-install-recommends -y build-essential libpq-dev libyaml-dev && \
33+
apt-get install --no-install-recommends -y build-essential git libpq-dev libyaml-dev pkg-config && \
3934
rm -rf /var/lib/apt/lists /var/cache/apt/archives
4035

4136
# Install application gems
42-
COPY Gemfile Gemfile.lock ./
37+
COPY Gemfile Gemfile.lock vendor ./
38+
4339
RUN bundle install && \
4440
rm -rf ~/.bundle/ "${BUNDLE_PATH}"/ruby/*/cache "${BUNDLE_PATH}"/ruby/*/bundler/gems/*/.git && \
4541
bundle exec bootsnap precompile --gemfile
@@ -54,21 +50,20 @@ RUN bundle exec bootsnap precompile app/ lib/
5450
RUN SECRET_KEY_BASE_DUMMY=1 ./bin/rails assets:precompile
5551

5652

53+
54+
5755
# Final stage for app image
5856
FROM base
5957

60-
6158
# Copy built artifacts: gems, application
6259
COPY --from=build "${BUNDLE_PATH}" "${BUNDLE_PATH}"
6360
COPY --from=build /rails /rails
6461

6562
# Run and own only the runtime files as a non-root user for security
66-
ARG UID=xxx \
67-
GID=1000
68-
RUN groupadd -f -g $GID rails && \
69-
useradd -u $UID -g $GID rails --create-home --shell /bin/bash && \
63+
RUN groupadd --system --gid 1000 rails && \
64+
useradd rails --uid 1000 --gid 1000 --create-home --shell /bin/bash && \
7065
chown -R rails:rails db log storage tmp
71-
USER rails:rails
66+
USER 1000:1000
7267

7368
# Entrypoint prepares the database.
7469
ENTRYPOINT ["/rails/bin/docker-entrypoint"]

test/results/private_gemserver/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ services:
1616
- "3000:3000"
1717
environment:
1818
secrets:
19-
- source: master_key
19+
- source: RAILS_MASTER_KEY
2020
target: /rails/config/master.key
2121

2222
secrets:
2323
gemserver_credentials:
2424
file: ./GEMSERVER_CREDENTIALS.secret.txt
2525

2626
secrets:
27-
master_key:
28-
file: ./config/master.key
27+
RAILS_MASTER_KEY
28+
file: ./config/master.key

test/results/private_gemserver_with_cache/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ services:
1616
- "3000:3000"
1717
environment:
1818
secrets:
19-
- source: master_key
19+
- source: RAILS_MASTER_KEY
2020
target: /rails/config/master.key
2121

2222
secrets:
2323
gemserver_credentials:
2424
file: ./GEMSERVER_CREDENTIALS.secret.txt
2525

2626
secrets:
27-
master_key:
28-
file: ./config/master.key
27+
RAILS_MASTER_KEY
28+
file: ./config/master.key

test/results/redis/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ services:
1515
environment:
1616
- REDIS_URL=redis://redis-db:6379
1717
secrets:
18-
- source: master_key
18+
- source: RAILS_MASTER_KEY
1919
target: /rails/config/master.key
2020
depends_on:
2121
redis-db:
@@ -25,5 +25,5 @@ services:
2525
image: redis
2626

2727
secrets:
28-
master_key:
29-
file: ./config/master.key
28+
RAILS_MASTER_KEY
29+
file: ./config/master.key

test/results/sidekiq/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ services:
1616
- REDIS_URL=redis://redis-db:6379
1717
- DATABASE_URL=postgres://root:password@postgres-db/
1818
secrets:
19-
- source: master_key
19+
- source: RAILS_MASTER_KEY
2020
target: /rails/config/master.key
2121
depends_on:
2222
redis-db:
@@ -54,5 +54,5 @@ services:
5454
condition: service_healthy
5555

5656
secrets:
57-
master_key:
58-
file: ./config/master.key
57+
RAILS_MASTER_KEY
58+
file: ./config/master.key

0 commit comments

Comments
 (0)