Accept migration failures

Ben Iofel · Ben Iofel · commit 2473d7a801d9 · 2024-08-08T15:15:34.000-04:00
diff --git a/internal/flypg/node.go b/internal/flypg/node.go
@@ -317,7 +317,8 @@ func (n *Node) PostInit(ctx context.Context) error {
 			}
 		case StandbyRoleName:
 			if err := n.migrateNodeNameIfNeeded(ctx, repConn); err != nil {
-				return fmt.Errorf("failed to migrate node name: %s", err)
+				log.Printf("[ERROR] failed to migrate node name: %s", err)
+				// We try to bring the standby up anyway
 			}
 
 			// Register existing standby to apply any configuration changes.

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,8 @@ func (n *Node) PostInit(ctx context.Context) error {`
`317`	`317`	`}`
`318`	`318`	`case StandbyRoleName:`
`319`	`319`	`if err := n.migrateNodeNameIfNeeded(ctx, repConn); err != nil {`
`320`		`- return fmt.Errorf("failed to migrate node name: %s", err)`
	`320`	`+ log.Printf("[ERROR] failed to migrate node name: %s", err)`
	`321`	`+ // We try to bring the standby up anyway`
`321`	`322`	`}`
`322`	`323`
`323`	`324`	`// Register existing standby to apply any configuration changes.`