fix zod error being thrown incorrectly while fetching data

Author: ExampleWasTaken

src/lib/apis/fetchData.ts

@@ -1,4 +1,4 @@
-import fetch, { Request } from 'node-fetch';
+import fetch, { Request, Response } from 'node-fetch';
 import { ZodSchema } from 'zod';
 import { Logger } from '../logger';
 
@@ -10,30 +10,32 @@ import { Logger } from '../logger';
  * @returns A promise that resolves to the expected type or rejects with an [Error](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error).
  */
 export const fetchData = async <ReturnType = unknown>(request: Request, zodSchema: ZodSchema<ReturnType>): Promise<ReturnType> => {
+    let response: Response;
     try {
-        const response = await fetch(request);
-
-        if (!response.ok) {
-            throw new Error(`HTTP Error. Status: ${response.status}`);
-        }
+        response = await fetch(request);
+    } catch (e) {
+        throw new Error(`An error occured while fetching data from ${request.url}: ${String(e)}`);
+    }
 
-        let data: unknown;
-        try {
-            data = await response.json();
-        } catch (e) {
-            throw new Error(`Could not parse JSON. Make sure the endpoint at ${request.url} returns valid JSON. Error: ${String(e)}`);
-        }
+    if (!response.ok) {
+        throw new Error(`HTTP Error. Status: ${response.status}`);
+    }
 
-        const result = zodSchema.safeParse(data);
+    let data: unknown;
+    try {
+        data = await response.json();
+    } catch (e) {
+        throw new Error(`Could not parse JSON. Make sure the endpoint at ${request.url} returns valid JSON. Error: ${String(e)}`);
+    }
 
-        if (!result.success) {
-            Logger.error('[zod] Data validation failed:');
-            result.error.issues.forEach((issue) => Logger.error(`Code: ${issue.code}, Path: ${issue.path.join('.')}, Message: ${issue.message}`));
-            throw result.error;
-        }
+    const result = zodSchema.safeParse(data);
 
-        return result.data;
-    } catch (e) {
-        throw new Error(`An error occured while fetching data from ${request.url}: ${String(e)}`);
+    if (!result.success) {
+        Logger.error('[zod] Data validation failed:');
+        result.error.issues.forEach((issue) => Logger.error(`Code: ${issue.code}, Path: ${issue.path.join('.')}, Message: ${issue.message}`));
+        console.log(data);
+        throw result.error;
     }
+
+    return result.data;
 };