Merge pull request #3 in CFA/coding-guidelines from CORRECT_NAMESPACES to master

* commit '21635939b8222007fa2271a3ea534e9c78c64c4d':
  Improved error message
  namespace declarations must be in UpperCamelCase

Author: Daniel Müller

custom-standards/Flyeralarm/Sniffs/File/NamespacesSniff.php

@@ -0,0 +1,45 @@
+<?php
+
+namespace flyeralarm\CodingGuidelines\Flyeralarm\Sniffs\File;
+
+use PHP_CodeSniffer\Sniffs\Sniff;
+use PHP_CodeSniffer\Files\File;
+
+class NamespacesSniff implements Sniff
+{
+    /**
+     * @return array
+     */
+    public function register()
+    {
+        return array(T_CLASS, T_ABSTRACT, T_TRAIT, T_INTERFACE);
+    }
+
+    /**
+     * @param File $phpcsFile
+     * @param int $stackPtr
+     * @return void
+     */
+    public function process(File $phpcsFile, $stackPtr)
+    {
+        $tokens = $phpcsFile->getTokens();
+        $ptr = -1;
+        while($ptr = $phpcsFile->findNext(T_NS_SEPARATOR, $ptr + 1)) {
+            if (ctype_upper($tokens[$ptr + 1]['content'][0]) === false) {
+                $phpcsFile->addError(
+                    'Namespace declarations after vendor name must be in UpperCamelCase',
+                    $stackPtr,
+                    'NamespaceDeclarationWithInvalidCapitalization'
+                );
+            }
+
+            if (strpos($tokens[$ptr + 1]['content'], '_') !== false) {
+                $phpcsFile->addError(
+                    'Namespace declarations after vendor name must be in UpperCamelCase',
+                    $stackPtr,
+                    'NamespaceDeclarationWithInvalidCapitalization'
+                );
+            }
+        }
+    }
+}

ruleset.xml

@@ -8,6 +8,7 @@
     <rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/File/ExceptionMessageSniff.php"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/File/ForbiddenKeywordsSniff.php"/>
+    <rule ref="./custom-standards/Flyeralarm/Sniffs/File/NamespacesSniff.php"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/File/NoClassKindSuffixSniff.php"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/Docblock/ReturnTypeSniff.php"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/Docblock/ExpectedExceptionMessageSniff.php"/>

tests/rules/classes/not-allowed/LowercaseNamespaceCapitalization.php

@@ -0,0 +1,10 @@
+<?php
+
+// @expectedError Namespace declarations after vendor name must be in UpperCamelCase
+
+namespace flyeralarm\lowerCase;
+
+class LowercaseNamespaceCapitalization
+{
+
+}

tests/rules/classes/not-allowed/UnderscoreNamespace.php

@@ -0,0 +1,10 @@
+<?php
+
+// @expectedError Namespace declarations after vendor name must be in UpperCamelCase
+
+namespace flyeralarm\under_score;
+
+class UnderscoreNamespace
+{
+
+}