Make sure the pattern was matched at least once.

Mirroar · web-flow · commit 68eb458f08c2 · 2022-06-27T12:41:55.000+02:00
diff --git a/custom-standards/Flyeralarm/Sniffs/Docblock/ReturnTypeSniff.php b/custom-standards/Flyeralarm/Sniffs/Docblock/ReturnTypeSniff.php
@@ -143,9 +143,9 @@ private function isStartingWithUppercaseLetter($singleCharacter)
      */
     private function checkReturnTypeShape(string $subject)
     {
-        preg_match_all('#(?<separator>\s*\|\s*)?(?<atom>[^<>\|]+)(?<generic><(?<nested>.*)>)?#', $subject, $matches);
+        $matched = preg_match_all('#(?<separator>\s*\|\s*)?(?<atom>[^<>\|]+)(?<generic><(?<nested>.*)>)?#', $subject, $matches);
 
-        if (implode('', $matches[0]) !== $subject) {
+        if (!$matched || implode('', $matches[0]) !== $subject) {
             throw new \InvalidArgumentException('Invalid structure in return type "' . $subject . '"');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -143,9 +143,9 @@ private function isStartingWithUppercaseLetter($singleCharacter)`
`143`	`143`	`*/`
`144`	`144`	`private function checkReturnTypeShape(string $subject)`
`145`	`145`	`{`
`146`		`- preg_match_all('#(?<separator>\s\\|\s)?(?<atom>[^<>\\|]+)(?<generic><(?<nested>.*)>)?#', $subject, $matches);`
	`146`	`+ $matched = preg_match_all('#(?<separator>\s\\|\s)?(?<atom>[^<>\\|]+)(?<generic><(?<nested>.*)>)?#', $subject, $matches);`
`147`	`147`
`148`		`- if (implode('', $matches[0]) !== $subject) {`
	`148`	`+ if (!$matched \|\| implode('', $matches[0]) !== $subject) {`
`149`	`149`	`throw new \InvalidArgumentException('Invalid structure in return type "' . $subject . '"');`
`150`	`150`	`}`
`151`	`151`