Merge pull request #1 in CFA/coding-guidelines from EXCEPTION_MESSAGE_TESTING to master

* commit '9b70e78baaa5505a36ee3853c90ec44fe1771021':
  Exception message testing

Author: Maximilian Grosch

custom-standards/Flyeralarm/Sniffs/File/ExceptionMessageSniff.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace flyeralarm\CodingGuidelines\Flyeralarm\Sniffs\File;
+
+use PHP_CodeSniffer\Sniffs\Sniff;
+use PHP_CodeSniffer\Files\File;
+
+class ExceptionMessageSniff implements Sniff
+{
+    /**
+     * @return array
+     */
+    public function register()
+    {
+        return array(T_CLASS);
+    }
+
+    /**
+     * @param File $phpcsFile
+     * @param int $stackPtr
+     * @return void
+     */
+    public function process(File $phpcsFile, $stackPtr)
+    {
+        $className = $phpcsFile->getDeclarationName($stackPtr);
+
+        if (strpos($className, 'Exception') === false) {
+            return;
+        }
+
+        $tokens = $phpcsFile->getTokens();
+        $ptr = -1;
+        while($ptr = $phpcsFile->findNext(T_CONSTANT_ENCAPSED_STRING, $ptr + 1)) {
+            if (strpos($tokens[$ptr]['content'], '!') !== false) {
+                $phpcsFile->addError(
+                    'Exclamationmarks are not allowed in Exceptionmessages',
+                    $stackPtr,
+                    'ExceptionMessageWithInvalidCharacter'
+                );
+            }
+
+            if (strpos($tokens[$ptr]['content'], '.') !== false) {
+                $phpcsFile->addError(
+                    'Full stops are not allowed in Exceptionmessages',
+                    $stackPtr,
+                    'ExceptionMessageWithInvalidCharacter'
+                );
+            }
+        }
+    }
+}

ruleset.xml

@@ -6,6 +6,7 @@
     <rule ref="Generic.Arrays.DisallowLongArraySyntax.Found"/>
     <rule ref="Generic.PHP.DisallowShortOpenTag"/>
     <rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
+    <rule ref="./custom-standards/Flyeralarm/Sniffs/File/ExceptionMessageSniff.php"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/File/NoClassKindSuffixSniff.php"/>
     <rule ref="./custom-standards/Flyeralarm/Sniffs/Docblock/ReturnTypeSniff.php"/>
 </ruleset>

tests/rules/classes/not-allowed/ExclamationException.php

@@ -0,0 +1,13 @@
+<?php
+// @expectedError Exclamationmarks are not allowed in Exceptionmessages
+
+class ExclamationException
+{
+    public function foobar()
+    {
+        echo 'Hi';
+        echo 'Wrong!';
+        echo 'Bye';
+        echo "Hola";
+    }
+}

tests/rules/classes/not-allowed/FullStopException.php

@@ -0,0 +1,13 @@
+<?php
+// @expectedError Full stops are not allowed in Exceptionmessages
+
+class FullStopException
+{
+    public function foobar()
+    {
+        echo 'Hi';
+        echo 'Bye';
+        echo "Hola";
+        echo "Ciao.";
+    }
+}