Merge pull request #11 in CFA/coding-guidelines from ignore-globals to master

* commit 'a1bbde796e2ff1cfe0a60f45ba2aa473e1b0b638':
  set $superGlobals to private
  add SuperGlobals test
  add SuperGlobals test
  fix superGlobals
  Ignore super globals from lower camel case check

Author: Frederik Schmitt

custom-standards/Flyeralarm/Sniffs/Variable/LowerCamelCaseSniff.php

@@ -8,6 +8,21 @@
 
 class LowerCamelCaseSniff implements Sniff
 {
+    /**
+     * @var array
+     */
+    private $superGlobals = [
+        'GLOBALS',
+        '_SERVER',
+        '_GET',
+        '_POST',
+        '_FILES',
+        '_COOKIE',
+        '_SESSION',
+        '_REQUEST',
+        '_ENV',
+    ];
+
     /**
      * @return array
      */
@@ -32,6 +47,10 @@ public function process(File $phpcsFile, $stackPtr)
             $variableName = $tokens[$variablePtr]['content'];
             $variableName = substr($variableName, 1);
 
+            if (in_array($variableName, $this->superGlobals)) {
+                continue;
+            }
+
             $isLowerCamelCase = Common::isCamelCaps($variableName, false, true, true);
             if ($isLowerCamelCase) {
                 continue;

tests/rules/variables/allowed/SuperGlobals.php

@@ -0,0 +1,13 @@
+<?php
+
+// @expectedPass
+
+$GLOBALS=true;
+$_SERVER=true;
+$_GET=true;
+$_POST=true;
+$_FILES=true;
+$_COOKIE=true;
+$_SESSION=true;
+$_REQUEST=true;
+$_ENV=true;