Merge pull request #22 from flyingrobots/chore/cjs-to-esm

fix: Convert all CommonJS to ESM

Author: flyingrobots

.eslintignore

@@ -0,0 +1,32 @@
+# Dependencies
+node_modules/
+package-lock.json
+pnpm-lock.yaml
+yarn.lock
+
+# Build outputs
+dist/
+build/
+coverage/
+.vitest/
+.nyc_output/
+
+# IDE
+.obsidian/
+.vscode/
+.idea/
+
+# Git
+.git/
+
+# Misc
+*.min.js
+*.min.css
+test-results/
+junit.xml
+*.tap
+*.log
+
+# Generated files
+migrations/
+.migration_archive/

.prettierignore

@@ -0,0 +1,15 @@
+{
+  "semi": true,
+  "trailingComma": "none",
+  "singleQuote": true,
+  "printWidth": 100,
+  "tabWidth": 2,
+  "useTabs": false,
+  "arrowParens": "always",
+  "endOfLine": "lf",
+  "bracketSpacing": true,
+  "bracketSameLine": false,
+  "proseWrap": "preserve",
+  "htmlWhitespaceSensitivity": "css",
+  "embeddedLanguageFormatting": "auto"
+}

.prettierrc.json

@@ -21,7 +21,7 @@ config();
 import { cli } from '../src/index.js';
 
 // Run the CLI with process arguments
-cli(process.argv).catch(error => {
+cli(process.argv).catch((error) => {
   console.error('Fatal error:', error.message);
   if (process.env.DEBUG) {
     console.error(error.stack);

bin/data.js

@@ -3,6 +3,20 @@ import promisePlugin from 'eslint-plugin-promise';
 
 export default [
   js.configs.recommended,
+  {
+    ignores: [
+      'node_modules/**',
+      '.obsidian/**',
+      'dist/**',
+      'build/**',
+      'coverage/**',
+      '*.min.js',
+      '.git/**',
+      '.vitest/**',
+      '.nyc_output/**',
+      'test-results/**'
+    ]
+  },
   {
     files: ['**/*.js'],
     languageOptions: {
@@ -21,43 +35,46 @@ export default [
       }
     },
     plugins: {
-      'promise': promisePlugin
+      promise: promisePlugin
     },
     rules: {
       // Promise-specific rules for proper async handling
       'promise/catch-or-return': 'error',
       'promise/always-return': 'error',
       'promise/no-return-wrap': 'error',
       'promise/param-names': 'error',
-      
+
       // Require await in async functions
       'require-await': 'error',
-      
+
       // Other async best practices
       'no-async-promise-executor': 'error',
       'no-await-in-loop': 'warn',
       'no-return-await': 'error',
       'prefer-promise-reject-errors': 'error',
-      
+
       // ESM-specific rules
       'no-console': 'off',
       'no-undef': 'error',
-      'no-unused-vars': ['error', { 
-        'argsIgnorePattern': '^_',
-        'varsIgnorePattern': '^_'
-      }],
-      
+      'no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_'
+        }
+      ],
+
       // Modern JavaScript best practices
       'prefer-const': 'error',
       'prefer-arrow-callback': 'error',
       'no-var': 'error',
       'object-shorthand': 'error',
-      'semi': ['error', 'always'],
-      'quotes': ['error', 'single', { 'avoidEscape': true }],
+      semi: ['error', 'always'],
+      quotes: ['error', 'single', { avoidEscape: true }],
       'comma-dangle': ['error', 'never'],
-      'indent': ['error', 2],
+      indent: ['error', 2],
       'no-trailing-spaces': 'error',
       'eol-last': 'error'
     }
   }
-];
+];

eslint.config.js

@@ -0,0 +1,55 @@
+#!/bin/bash
+# Script to systematically convert CommonJS to ESM
+
+set -e
+
+echo "🔧 Converting CommonJS to ESM..."
+
+# Function to convert a single file
+convert_file() {
+  local file=$1
+  echo "Converting: $file"
+  
+  # Create backup
+  cp "$file" "$file.bak"
+  
+  # Convert require statements
+  # const x = require('y') -> import x from 'y'
+  sed -i '' "s/const \([a-zA-Z_][a-zA-Z0-9_]*\) = require(\(.*\))/import \1 from \2/g" "$file"
+  
+  # const { x, y } = require('z') -> import { x, y } from 'z'
+  sed -i '' "s/const { \(.*\) } = require(\(.*\))/import { \1 } from \2/g" "$file"
+  
+  # Fix relative imports - add .js extension
+  sed -i '' "s/from '\(\.\.[^']*\)'/from '\1.js'/g" "$file"
+  sed -i '' 's/from "\(\.\.[^"]*\)"/from "\1.js"/g' "$file"
+  
+  # Fix double .js.js
+  sed -i '' "s/\.js\.js'/.js'/g" "$file"
+  sed -i '' 's/\.js\.js"/.js"/g' "$file"
+  
+  # module.exports = x -> export default x
+  sed -i '' 's/^module\.exports = \(.*\);$/export default \1;/g' "$file"
+  
+  # module.exports = { -> export {
+  sed -i '' 's/^module\.exports = {$/export {/g' "$file"
+  
+  # exports.x = y -> export const x = y
+  sed -i '' 's/^exports\.\([a-zA-Z_][a-zA-Z0-9_]*\) = \(.*\);$/export const \1 = \2;/g' "$file"
+  
+  echo "✓ Converted $file"
+}
+
+# Convert each file
+for file in $(cat /tmp/all-commonjs-files.txt); do
+  if [[ "$file" == *"codemods"* ]]; then
+    echo "Skipping codemod file: $file"
+    continue
+  fi
+  convert_file "$file"
+done
+
+echo "✅ Conversion complete!"
+echo ""
+echo "🔍 Checking for remaining CommonJS patterns..."
+grep -r "require(" . --include="*.js" --exclude-dir=node_modules --exclude-dir=.obsidian --exclude="*.bak" | grep -v "codemods" | wc -l

fix-commonjs.sh

@@ -0,0 +1,34 @@
+#!/bin/bash
+
+# Fix ESLint errors systematically
+
+echo "🔧 Fixing ESLint errors..."
+
+# Fix unused variables by prefixing with underscore
+echo "📝 Fixing unused variables..."
+find ./starfleet ./src ./test -name "*.js" -type f | while read file; do
+  # Fix unused error variables
+  sed -i '' 's/catch (error)/catch (_error)/g' "$file"
+  sed -i '' 's/\.catch(error/\.catch(_error/g' "$file"
+  
+  # Fix unused function parameters
+  sed -i '' 's/function([^)]*\boptions\b/function(_options/g' "$file"
+  sed -i '' 's/(\([^)]*\), reject)/(\1, _reject)/g' "$file"
+done
+
+# Remove redundant await on return
+echo "📝 Removing redundant await on return..."
+find ./starfleet ./src ./test -name "*.js" -type f | while read file; do
+  sed -i '' 's/return await /return /g' "$file"
+done
+
+# Fix async functions with no await by removing async
+echo "📝 Fixing async functions with no await..."
+find ./starfleet ./src ./test -name "*.js" -type f | while read file; do
+  # This is more complex, so we'll just flag them for now
+  grep -n "Async.*has no 'await'" "$file" 2>/dev/null && echo "  ⚠️ $file has async functions without await"
+done
+
+echo "✅ Basic fixes complete!"
+echo "🔍 Running ESLint again..."
+pnpm eslint src starfleet test 2>&1 | tail -5

fix-eslint.sh

@@ -45,7 +45,6 @@
   ],
   "author": "Flyingrobots Development Team",
   "license": "MIT",
-  "dependencies": {},
   "devDependencies": {
     "@eslint/js": "^9.34.0",
     "@typescript-eslint/eslint-plugin": "^8.41.0",
@@ -54,6 +53,9 @@
     "eslint": "^9.34.0",
     "eslint-plugin-promise": "^7.2.1",
     "husky": "^9.1.7",
+    "jscodeshift": "^17.3.0",
+    "prettier": "^3.6.2",
+    "recast": "^0.23.11",
     "vitest": "^2.0.0"
   },
   "engines": {