User welcome message gets sent twice

[awkkih]

Explain the issue.

If you and another person click at the same time in the "Approve verification" button, the welcoming message gets sent twice.

How to recreate?

Click the "Approve" button with another person at the same time.

Anything else?

To fix this I think it's as simple as putting a verification to see if the player already has the role. If they do, just don't do anything or send an ephemeral message saying that they're already verified.

[joshbker]

I think this is caused by another bug - #195. Let me know if it's not though.

[awkkih]

Hm, I don't really think it's related to that. It's nothing about the profile URL but instead to the delay between approving and adding the role.

[joshbker]

Oh right, so it happens on ones where the URL is short enough that it doesn't bug? It just takes enough time normally that if it's pressed near enough the same time it duplicates still?