Add wait in image builder protocol #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicBboy
changed the title
cosmicBboy
force-pushed
the
nielsb/remote-builder-wait
branch
from
830ad57 to
397db46
Compare
Contributor
wild-endeavor
left a comment
wild-endeavor
left a comment
There was a problem hiding this comment.
@kumare3 should we introduce a build object? I'm a little worried about the build function sometimes returning one thing and sometimes returning another. it's a bit too implicit i feel.
kumare3
reviewed
Jan 26, 2026
src/flyte/_build.py
Outdated
| wait: Wait for the build to finish. If wait is False, the function will return immediately and the build will | ||
| run in the background. | ||
| Returns: | ||
| The image URI. If wait is False when using the remote image builder, the function will return the build image |
Contributor
There was a problem hiding this comment.
I agree, making this an explicit object will be better.
Like ImageBuild object that contains, build job url and uri this can be useful in other places too
Contributor
|
Also after this PR https://github.com/flyteorg/flyte-sdk/pull/565/changes#r2728932092 is ready we should migrate the asyncio.to_thread to this. |
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
kumare3
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to
flyte.buildto not wait for the image build to complete. Note: when the builder isremoteandwait=False, thebuildmethod will return the url to the image build task instead of the fully qualified URI