Skip to content

Commit 152f2e9

Browse files
authored
chore: No more checkstyle (#320)
# TL;DR Remove checkstyle maven plugin. ## Type - [ ] Bug Fix - [ ] Feature - [ ] Plugin ## Are all requirements met? - [x] Code completed - [ ] Smoke tested - [ ] Unit tests added - [ ] Code documentation added - [ ] Any pending items have an associated Issue ## Complete description Checkstyle has always been a pain to use and we can hardly recall it really helps with anything. In #318, checkstyle disagrees with spotless, which is very much pointless. ## Tracking Issue _NA_ ## Follow-up issue _NA_ Signed-off-by: Hongxin Liang <[email protected]>
1 parent 7693445 commit 152f2e9

File tree

2 files changed

+0
-157
lines changed

2 files changed

+0
-157
lines changed

checkstyle.xml

Lines changed: 0 additions & 133 deletions
This file was deleted.

pom.xml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -656,26 +656,6 @@
656656
</execution>
657657
</executions>
658658
</plugin>
659-
<plugin>
660-
<artifactId>maven-checkstyle-plugin</artifactId>
661-
<version>3.1.1</version>
662-
<configuration>
663-
<configLocation>checkstyle.xml</configLocation>
664-
<consoleOutput>true</consoleOutput>
665-
<!-- Remove or switch to false to keep building even with checkstyle errors -->
666-
<failOnViolation>true</failOnViolation>
667-
<logViolationsToConsole>true</logViolationsToConsole>
668-
<encoding>utf-8</encoding>
669-
</configuration>
670-
<executions>
671-
<execution>
672-
<goals>
673-
<goal>check</goal>
674-
</goals>
675-
<phase>verify</phase>
676-
</execution>
677-
</executions>
678-
</plugin>
679659
<plugin>
680660
<groupId>org.apache.rat</groupId>
681661
<artifactId>apache-rat-plugin</artifactId>
@@ -688,7 +668,6 @@
688668
<excludes>
689669
<!-- Generated during build to shade dependencies -->
690670
<exclude>**/dependency-reduced-pom.xml</exclude>
691-
<exclude>**/target/checkstyle-result.xml</exclude>
692671
<exclude>**/target/javadoc-bundle-options/javadoc-options-javadoc-resources.xml</exclude>
693672
</excludes>
694673
</configuration>
@@ -795,9 +774,6 @@
795774
<groupId>org.apache.rat</groupId>
796775
<artifactId>apache-rat-plugin</artifactId>
797776
</plugin>
798-
<plugin>
799-
<artifactId>maven-checkstyle-plugin</artifactId>
800-
</plugin>
801777
<plugin>
802778
<artifactId>maven-enforcer-plugin</artifactId>
803779
</plugin>

0 commit comments

Comments
 (0)