Skip to content

Commit 77c5bc1

Browse files
committed
Reformat with ruff
Signed-off-by: thomasjhuang <thomashuang63@gmail.com>
1 parent 8daefc5 commit 77c5bc1

File tree

7 files changed

+19
-18
lines changed

7 files changed

+19
-18
lines changed

flytekit/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@
146146
from flytekit.image_spec import ImageSpec
147147
from flytekit.loggers import LOGGING_RICH_FMT_ENV_VAR, logger
148148
from flytekit.models.common import Annotations, AuthRole, Labels
149-
from flytekit.models.concurrency import ConcurrencyPolicy, ConcurrencyLimitBehavior
149+
from flytekit.models.concurrency import ConcurrencyLimitBehavior, ConcurrencyPolicy
150150
from flytekit.models.core.execution import WorkflowExecutionPhase
151151
from flytekit.models.core.types import BlobType
152152
from flytekit.models.documentation import Description, Documentation, SourceCode

flytekit/core/launch_plan.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from typing import Any, Callable, Dict, List, Optional, Type
55

66
from flytekit.core import workflow as _annotated_workflow
7-
from flytekit.models.concurrency import ConcurrencyPolicy
87
from flytekit.core.context_manager import FlyteContext, FlyteContextManager, FlyteEntities
98
from flytekit.core.interface import Interface, transform_function_to_interface, transform_inputs_to_parameters
109
from flytekit.core.promise import create_and_link_node, translate_inputs_to_literals
@@ -15,6 +14,7 @@
1514
from flytekit.models import literals as _literal_models
1615
from flytekit.models import schedule as _schedule_model
1716
from flytekit.models import security
17+
from flytekit.models.concurrency import ConcurrencyPolicy
1818
from flytekit.models.core import workflow as _workflow_model
1919

2020

flytekit/models/concurrency.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ class ConcurrencyPolicy(_common.FlyteIdlEntity):
2222
"""
2323
Defines the concurrency policy for a launch plan.
2424
"""
25+
2526
def __init__(self, max_concurrency: int, behavior: ConcurrencyLimitBehavior = None):
2627
self._max_concurrency = max_concurrency
2728
self._behavior = behavior if behavior is not None else ConcurrencyLimitBehavior.SKIP

flytekit/models/launch_plan.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
from flytekit.models import literals as _literals
99
from flytekit.models import schedule as _schedule
1010
from flytekit.models import security
11-
from flytekit.models.core import identifier as _identifier
1211
from flytekit.models.concurrency import ConcurrencyPolicy
12+
from flytekit.models.core import identifier as _identifier
1313

1414

1515
class LaunchPlanMetadata(_common.FlyteIdlEntity):
@@ -310,7 +310,8 @@ def from_flyte_idl(cls, pb2):
310310
else None,
311311
overwrite_cache=pb2.overwrite_cache if pb2.overwrite_cache else None,
312312
concurrency_policy=ConcurrencyPolicy.from_flyte_idl(pb2.concurrency_policy)
313-
if pb2.HasField("concurrency_policy") else None,
313+
if pb2.HasField("concurrency_policy")
314+
else None,
314315
)
315316

316317

flytekit/tools/translator.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@
3232
from flytekit.models import launch_plan as _launch_plan_models
3333
from flytekit.models.admin import workflow as admin_workflow_models
3434
from flytekit.models.admin.workflow import WorkflowSpec
35+
from flytekit.models.concurrency import ConcurrencyPolicy
3536
from flytekit.models.core import identifier as _identifier_model
3637
from flytekit.models.core import workflow as _core_wf
3738
from flytekit.models.core import workflow as workflow_model
3839
from flytekit.models.core.workflow import ApproveCondition, GateNode, SignalCondition, SleepCondition, TaskNodeOverrides
3940
from flytekit.models.core.workflow import ArrayNode as ArrayNodeModel
4041
from flytekit.models.core.workflow import BranchNode as BranchNodeModel
4142
from flytekit.models.task import TaskSpec, TaskTemplate
42-
from flytekit.models.concurrency import ConcurrencyPolicy
4343

4444
FlyteLocalEntity = Union[
4545
PythonTask,
@@ -362,8 +362,7 @@ def get_serializable_launch_plan(
362362
concurrency_policy = None
363363
if entity.concurrency is not None:
364364
concurrency_policy = ConcurrencyPolicy(
365-
max_concurrency=entity.concurrency.max_concurrency,
366-
behavior=entity.concurrency.behavior
365+
max_concurrency=entity.concurrency.max_concurrency, behavior=entity.concurrency.behavior
367366
)
368367

369368
lps = _launch_plan_models.LaunchPlanSpec(

tests/flytekit/unit/models/test_concurrency.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,24 @@
55

66
def test_concurrency_limit_behavior():
77
assert ConcurrencyLimitBehavior.SKIP == _launch_plan_idl.ConcurrencyLimitBehavior.SKIP
8-
8+
99
# Test enum to string conversion
1010
assert ConcurrencyLimitBehavior.enum_to_string(ConcurrencyLimitBehavior.SKIP) == "SKIP"
1111
assert ConcurrencyLimitBehavior.enum_to_string(999) == "<UNKNOWN>"
1212

1313

1414
def test_concurrency_policy():
1515
policy = ConcurrencyPolicy(max_concurrency=1, behavior=ConcurrencyLimitBehavior.SKIP)
16-
16+
1717
assert policy.max_concurrency == 1
1818
assert policy.behavior == ConcurrencyLimitBehavior.SKIP
19-
19+
2020
# Test serialization to protobuf
2121
pb = policy.to_flyte_idl()
2222
assert isinstance(pb, _launch_plan_idl.ConcurrencyPolicy)
2323
assert pb.max == 1
2424
assert pb.behavior == _launch_plan_idl.ConcurrencyLimitBehavior.SKIP
25-
25+
2626
# Test deserialization from protobuf
2727
policy2 = ConcurrencyPolicy.from_flyte_idl(pb)
2828
assert policy2.max_concurrency == 1
@@ -33,9 +33,9 @@ def test_concurrency_policy_with_different_max():
3333
# Test with a higher max value
3434
policy = ConcurrencyPolicy(max_concurrency=5, behavior=ConcurrencyLimitBehavior.SKIP)
3535
assert policy.max_concurrency == 5
36-
36+
3737
pb = policy.to_flyte_idl()
3838
assert pb.max == 5
39-
39+
4040
policy2 = ConcurrencyPolicy.from_flyte_idl(pb)
41-
assert policy2.max_concurrency == 5
41+
assert policy2.max_concurrency == 5

tests/flytekit/unit/tools/test_translator_concurrency.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@ def my_wf(a: int) -> int:
3535
default_inputs={"a": 10},
3636
concurrency=concurrency_policy
3737
)
38-
38+
3939
entity_mapping = OrderedDict()
4040
serialized_lp = get_serializable(entity_mapping, serialization_settings, lp)
41-
41+
4242
assert serialized_lp.spec.concurrency_policy is not None
4343
assert serialized_lp.spec.concurrency_policy.max_concurrency == 5
4444
assert serialized_lp.spec.concurrency_policy.behavior == ConcurrencyLimitBehavior.SKIP
45-
45+
4646
# Create a launch plan without concurrency policy
4747
lp_no_concurrency = launch_plan.LaunchPlan.get_or_create(
4848
workflow=my_wf,
@@ -51,6 +51,6 @@ def my_wf(a: int) -> int:
5151
)
5252
entity_mapping_2 = OrderedDict()
5353
serialized_lp_2 = get_serializable(entity_mapping_2, serialization_settings, lp_no_concurrency)
54-
54+
5555
# Verify concurrency policy is not set
5656
assert serialized_lp_2.spec.concurrency_policy is None

0 commit comments

Comments
 (0)