diff --git a/.github/workflows/pythonpublish.yml b/.github/workflows/pythonpublish.yml index 407ee81ab9..7683cc64c0 100644 --- a/.github/workflows/pythonpublish.yml +++ b/.github/workflows/pythonpublish.yml @@ -23,7 +23,7 @@ jobs: id: bump run: | # from 'refs/tags/v1.2.3' get 1.2.3 - VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||') + VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||') echo "version=$VERSION" >> $GITHUB_OUTPUT shell: bash - name: Build and publish @@ -36,7 +36,7 @@ jobs: - name: Autobump plugin version run: | # from 'refs/tags/v1.2.3' get 1.2.3 - VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||') + VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||') VERSION=$VERSION make -C plugins update_all_versions shell: bash - name: Build all Plugins and publish @@ -50,7 +50,7 @@ jobs: id: pypiwait run: | # from 'refs/tags/v1.2.3 get 1.2.3' and make sure it's not an empty string - VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||') + VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||') if [ -z "$VERSION" ] then echo "No tagged version found, exiting" diff --git a/tests/flytekit/unit/core/test_generice_idl_type_engine.py b/tests/flytekit/unit/core/test_generice_idl_type_engine.py index ce3ca1fad2..7dcc9cbed6 100644 --- a/tests/flytekit/unit/core/test_generice_idl_type_engine.py +++ b/tests/flytekit/unit/core/test_generice_idl_type_engine.py @@ -2704,7 +2704,7 @@ def test_union_in_dataclass(): lv = tf.to_literal(ctx, o, pt, lt) ot = tf.to_python_value(ctx, lv=lv, expected_python_type=pt) - return o == ot + assert o == ot assert o.result.schema.remote_path == ot.result.schema.remote_path assert o.result.number == ot.result.number assert o.schema.remote_path == ot.schema.remote_path diff --git a/tests/flytekit/unit/core/test_type_engine.py b/tests/flytekit/unit/core/test_type_engine.py index 0dfb0ddbb3..93d5d6af67 100644 --- a/tests/flytekit/unit/core/test_type_engine.py +++ b/tests/flytekit/unit/core/test_type_engine.py @@ -2713,7 +2713,7 @@ def test_union_in_dataclass(): lv = tf.to_literal(ctx, o, pt, lt) ot = tf.to_python_value(ctx, lv=lv, expected_python_type=pt) - return o == ot + assert o == ot assert o.result.schema.remote_path == ot.result.schema.remote_path assert o.result.number == ot.result.number assert o.schema.remote_path == ot.schema.remote_path